Re: [PATCH 01/10] mm/mmap: Replace SHM_HUGE_MASK with MAP_HUGE_MASK inside mmap_pgoff

2016-04-13 Thread Michal Hocko
On Thu 07-04-16 11:07:35, Anshuman Khandual wrote: > The commit 091d0d55b286 ("shm: fix null pointer deref when userspace > specifies invalid hugepage size") had replaced MAP_HUGE_MASK with > SHM_HUGE_MASK. Though both of them contain the same numeric value of > 0x3f, MAP_HUGE_MASK flag sounds

Re: [PATCH 01/10] mm/mmap: Replace SHM_HUGE_MASK with MAP_HUGE_MASK inside mmap_pgoff

2016-04-13 Thread Michal Hocko
On Thu 07-04-16 11:07:35, Anshuman Khandual wrote: > The commit 091d0d55b286 ("shm: fix null pointer deref when userspace > specifies invalid hugepage size") had replaced MAP_HUGE_MASK with > SHM_HUGE_MASK. Though both of them contain the same numeric value of > 0x3f, MAP_HUGE_MASK flag sounds

Re: [PATCH 01/10] mm/mmap: Replace SHM_HUGE_MASK with MAP_HUGE_MASK inside mmap_pgoff

2016-04-07 Thread Balbir Singh
On 07/04/16 15:37, Anshuman Khandual wrote: > The commit 091d0d55b286 ("shm: fix null pointer deref when userspace > specifies invalid hugepage size") had replaced MAP_HUGE_MASK with > SHM_HUGE_MASK. Though both of them contain the same numeric value of > 0x3f, MAP_HUGE_MASK flag sounds more

Re: [PATCH 01/10] mm/mmap: Replace SHM_HUGE_MASK with MAP_HUGE_MASK inside mmap_pgoff

2016-04-07 Thread Balbir Singh
On 07/04/16 15:37, Anshuman Khandual wrote: > The commit 091d0d55b286 ("shm: fix null pointer deref when userspace > specifies invalid hugepage size") had replaced MAP_HUGE_MASK with > SHM_HUGE_MASK. Though both of them contain the same numeric value of > 0x3f, MAP_HUGE_MASK flag sounds more

[PATCH 01/10] mm/mmap: Replace SHM_HUGE_MASK with MAP_HUGE_MASK inside mmap_pgoff

2016-04-06 Thread Anshuman Khandual
The commit 091d0d55b286 ("shm: fix null pointer deref when userspace specifies invalid hugepage size") had replaced MAP_HUGE_MASK with SHM_HUGE_MASK. Though both of them contain the same numeric value of 0x3f, MAP_HUGE_MASK flag sounds more appropriate than the other one in the context. Hence

[PATCH 01/10] mm/mmap: Replace SHM_HUGE_MASK with MAP_HUGE_MASK inside mmap_pgoff

2016-04-06 Thread Anshuman Khandual
The commit 091d0d55b286 ("shm: fix null pointer deref when userspace specifies invalid hugepage size") had replaced MAP_HUGE_MASK with SHM_HUGE_MASK. Though both of them contain the same numeric value of 0x3f, MAP_HUGE_MASK flag sounds more appropriate than the other one in the context. Hence