Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-21 Thread Serge Semin
On Sat, Feb 20, 2021 at 04:49:22PM +0100, Andrew Lunn wrote: > > If in doubt, leaving the patch as is would be fine with me. > > The patch is O.K. as is, no need to export something so simple for a > single users. When the next user come along, we can reconsider. Ok. Thanks for clarification. I

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-20 Thread Andrew Lunn
> If in doubt, leaving the patch as is would be fine with me. The patch is O.K. as is, no need to export something so simple for a single users. When the next user come along, we can reconsider. Andrew

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-20 Thread Heiner Kallweit
On 20.02.2021 10:02, Serge Semin wrote: > On Thu, Feb 11, 2021 at 10:39:41AM +, Russell King - ARM Linux admin > wrote: >> On Wed, Feb 10, 2021 at 07:47:20PM +0300, Serge Semin wrote: >>> On Tue, Feb 09, 2021 at 10:56:46AM +, Russell King - ARM Linux admin >>> wrote: On Tue, Feb 09,

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-20 Thread Serge Semin
On Thu, Feb 11, 2021 at 10:39:41AM +, Russell King - ARM Linux admin wrote: > On Wed, Feb 10, 2021 at 07:47:20PM +0300, Serge Semin wrote: > > On Tue, Feb 09, 2021 at 10:56:46AM +, Russell King - ARM Linux admin > > wrote: > > > On Tue, Feb 09, 2021 at 11:37:29AM +0100, Heiner Kallweit

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-11 Thread Serge Semin
On Thu, Feb 11, 2021 at 10:39:41AM +, Russell King - ARM Linux admin wrote: > On Wed, Feb 10, 2021 at 07:47:20PM +0300, Serge Semin wrote: > > On Tue, Feb 09, 2021 at 10:56:46AM +, Russell King - ARM Linux admin > > wrote: > > > On Tue, Feb 09, 2021 at 11:37:29AM +0100, Heiner Kallweit

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-11 Thread Russell King - ARM Linux admin
On Wed, Feb 10, 2021 at 07:47:20PM +0300, Serge Semin wrote: > On Tue, Feb 09, 2021 at 10:56:46AM +, Russell King - ARM Linux admin > wrote: > > On Tue, Feb 09, 2021 at 11:37:29AM +0100, Heiner Kallweit wrote: > > > Right, adding something like a genphy_{read,write}_mmd() doesn't make > > >

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-10 Thread Serge Semin
On Tue, Feb 09, 2021 at 10:56:46AM +, Russell King - ARM Linux admin wrote: > On Tue, Feb 09, 2021 at 11:37:29AM +0100, Heiner Kallweit wrote: > > Right, adding something like a genphy_{read,write}_mmd() doesn't make > > too much sense for now. What I meant is just exporting

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-09 Thread Russell King - ARM Linux admin
On Tue, Feb 09, 2021 at 11:37:29AM +0100, Heiner Kallweit wrote: > Right, adding something like a genphy_{read,write}_mmd() doesn't make > too much sense for now. What I meant is just exporting mmd_phy_indirect(). > Then you don't have to open-code the first three steps of a mmd read/write. > And

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-09 Thread Russell King - ARM Linux admin
On Tue, Feb 09, 2021 at 01:15:28PM +0300, Serge Semin wrote: > On Mon, Feb 08, 2021 at 09:14:02PM +0100, Heiner Kallweit wrote: > > Nice analysis. Alternatively to duplicating this code piece we could > > export mmd_phy_indirect(). But up to you. > > I also considered creating a generic method to

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-09 Thread Heiner Kallweit
On 09.02.2021 11:15, Serge Semin wrote: > On Mon, Feb 08, 2021 at 09:14:02PM +0100, Heiner Kallweit wrote: >> On 08.02.2021 15:03, Serge Semin wrote: >>> It has been noticed that RTL8211E PHY stops detecting and reporting events >>> when EEE is successfully advertised and RXC stopping in LPI is

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-09 Thread Serge Semin
On Mon, Feb 08, 2021 at 09:14:02PM +0100, Heiner Kallweit wrote: > On 08.02.2021 15:03, Serge Semin wrote: > > It has been noticed that RTL8211E PHY stops detecting and reporting events > > when EEE is successfully advertised and RXC stopping in LPI is enabled. > > The freeze happens right after

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-08 Thread Heiner Kallweit
On 08.02.2021 15:03, Serge Semin wrote: > It has been noticed that RTL8211E PHY stops detecting and reporting events > when EEE is successfully advertised and RXC stopping in LPI is enabled. > The freeze happens right after 3.0.10 bit (PC1R "Clock Stop Enable" > register) is set. At the same time

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-08 Thread Andrew Lunn
> Hi Andrew, > > I honestly tried to find any doc with a glimpse of errata for RTL8211E > PHY, but with no luck. Official datasheet didn't have any info regarding > possible hw bugs too. Thus I had no choice but to find a fix of the > problem myself. > > It took me some time to figure out why

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-08 Thread Serge Semin
On Mon, Feb 08, 2021 at 04:27:36PM +0100, Andrew Lunn wrote: > On Mon, Feb 08, 2021 at 05:03:22PM +0300, Serge Semin wrote: > > It has been noticed that RTL8211E PHY stops detecting and reporting events > > when EEE is successfully advertised and RXC stopping in LPI is enabled. > > The freeze

Re: [PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-08 Thread Andrew Lunn
On Mon, Feb 08, 2021 at 05:03:22PM +0300, Serge Semin wrote: > It has been noticed that RTL8211E PHY stops detecting and reporting events > when EEE is successfully advertised and RXC stopping in LPI is enabled. > The freeze happens right after 3.0.10 bit (PC1R "Clock Stop Enable" > register) is

[PATCH 01/20] net: phy: realtek: Fix events detection failure in LPI mode

2021-02-08 Thread Serge Semin
It has been noticed that RTL8211E PHY stops detecting and reporting events when EEE is successfully advertised and RXC stopping in LPI is enabled. The freeze happens right after 3.0.10 bit (PC1R "Clock Stop Enable" register) is set. At the same time LED2 stops blinking as if EEE mode has been