Re: [PATCH 02/14] drbd: remove dead code in device_to_statistics

2020-07-28 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn

[PATCH 02/14] drbd: remove dead code in device_to_statistics

2020-07-26 Thread Christoph Hellwig
Ever since the switch to blk-mq, a lower device not used for VM writeback will not be marked congested, so the check will never trigger. Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_nl.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/block/drbd/drbd_nl.c

[PATCH 02/14] drbd: remove dead code in device_to_statistics

2020-07-24 Thread Christoph Hellwig
Ever since the switch to blk-mq, a lower device not used for VM writeback will not be marked congested, so the check will never trigger. Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_nl.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/block/drbd/drbd_nl.c

Re: [PATCH 02/14] drbd: remove dead code in device_to_statistics

2020-07-22 Thread Johannes Thumshirn
On 22/07/2020 09:07, Christoph Hellwig wrote: > As far as I can tell this is a netlink user ABI. > I guess it has to stay then

Re: [PATCH 02/14] drbd: remove dead code in device_to_statistics

2020-07-22 Thread Christoph Hellwig
On Wed, Jul 22, 2020 at 07:03:21AM +, Johannes Thumshirn wrote: > On 22/07/2020 08:28, Christoph Hellwig wrote: > > Ever since the switch to blk-mq, a lower device not use by VM >in-use/used? ~^ Yeah, this should be used. > Also this looks like the

Re: [PATCH 02/14] drbd: remove dead code in device_to_statistics

2020-07-22 Thread Johannes Thumshirn
On 22/07/2020 08:28, Christoph Hellwig wrote: > Ever since the switch to blk-mq, a lower device not use by VM in-use/used? ~^ Also this looks like the last user of 'dev_lower_blocked' so it could be removed from device_statistics if it's not an ABI (not

[PATCH 02/14] drbd: remove dead code in device_to_statistics

2020-07-22 Thread Christoph Hellwig
Ever since the switch to blk-mq, a lower device not use by VM writeback will not be marked congested, so the check will never trigger. Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_nl.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/block/drbd/drbd_nl.c

[PATCH 02/14] drbd: remove dead code in device_to_statistics

2020-07-20 Thread Christoph Hellwig
Ever since the switch to blk-mq, a lower device not use by VM writeback will not be marked congested, so the check will never trigger. Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_nl.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/block/drbd/drbd_nl.c