> I assume that if an error happened in a pipe set -e; would catch it.
> But I did not check that - I normally just adds set -e; without much thought.
No, you need set -o pipefail for that (which is a bashism).
Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe
On Tue, Nov 20, 2007 at 11:10:15PM -0800, Roland McGrath wrote:
> > > +# This makes sure the $(obj) subdirectory exists even though vdso32/
> > > +# is not a kbuild sub-make subdirectory.
> > > +override obj-dirs = $(dir $(obj)) $(obj)/vdso32/
> >
> > Should we teach kbuild to create dirs
> > +# This makes sure the $(obj) subdirectory exists even though vdso32/
> > +# is not a kbuild sub-make subdirectory.
> > +override obj-dirs = $(dir $(obj)) $(obj)/vdso32/
>
> Should we teach kbuild to create dirs specified in targets?
> Or we could 'fix' it so you do not need the override.
Hi Roland.
Some minor things below.
In general I like the simplification of this
area and having it moved out of kernel/Makefile is the-right-thing.
Sam
On Mon, Nov 19, 2007 at 02:05:32PM -0800, Roland McGrath wrote:
>
> This builds the 32-bit vDSO images in the arch/x86/vdso
Hi Roland.
Some minor things below.
In general I like the simplification of this
area and having it moved out of kernel/Makefile is the-right-thing.
Sam
On Mon, Nov 19, 2007 at 02:05:32PM -0800, Roland McGrath wrote:
This builds the 32-bit vDSO images in the arch/x86/vdso
+# This makes sure the $(obj) subdirectory exists even though vdso32/
+# is not a kbuild sub-make subdirectory.
+override obj-dirs = $(dir $(obj)) $(obj)/vdso32/
Should we teach kbuild to create dirs specified in targets?
Or we could 'fix' it so you do not need the override.
Something
On Tue, Nov 20, 2007 at 11:10:15PM -0800, Roland McGrath wrote:
+# This makes sure the $(obj) subdirectory exists even though vdso32/
+# is not a kbuild sub-make subdirectory.
+override obj-dirs = $(dir $(obj)) $(obj)/vdso32/
Should we teach kbuild to create dirs specified in
I assume that if an error happened in a pipe set -e; would catch it.
But I did not check that - I normally just adds set -e; without much thought.
No, you need set -o pipefail for that (which is a bashism).
Thanks,
Roland
-
To unsubscribe from this list: send the line unsubscribe linux-kernel
This builds the 32-bit vDSO images in the arch/x86/vdso subdirectory.
Nothing uses the images yet, but this paves the way for consolidating
the vDSO build logic all in one place. The new images use a linker
script sharing the layout parts from vdso-layout.lds.S with the 64-bit
vDSO. A new
This builds the 32-bit vDSO images in the arch/x86/vdso subdirectory.
Nothing uses the images yet, but this paves the way for consolidating
the vDSO build logic all in one place. The new images use a linker
script sharing the layout parts from vdso-layout.lds.S with the 64-bit
vDSO. A new
10 matches
Mail list logo
