Re: [PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

On Thu, Aug 03, 2017 at 10:14:32AM +0200, Linus Walleij wrote: > On Wed, Jul 19, 2017 at 4:59 PM, Laxman Dewangan wrote: > > On Wednesday 19 July 2017 06:55 PM, Johan Hovold wrote: > > >> I guess the latter is fine, even if it is likely to amount to a fair bit > >> of

Re: [PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

On Thu, Aug 03, 2017 at 10:14:32AM +0200, Linus Walleij wrote: > On Wed, Jul 19, 2017 at 4:59 PM, Laxman Dewangan wrote: > > On Wednesday 19 July 2017 06:55 PM, Johan Hovold wrote: > > >> I guess the latter is fine, even if it is likely to amount to a fair bit > >> of debugging world wide. > >>

Re: [PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

On Wed, Jul 19, 2017 at 4:59 PM, Laxman Dewangan wrote: > On Wednesday 19 July 2017 06:55 PM, Johan Hovold wrote: >> I guess the latter is fine, even if it is likely to amount to a fair bit >> of debugging world wide. >> >> Perhaps all this can still be avoided by adding

Re: [PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

On Wed, Jul 19, 2017 at 4:59 PM, Laxman Dewangan wrote: > On Wednesday 19 July 2017 06:55 PM, Johan Hovold wrote: >> I guess the latter is fine, even if it is likely to amount to a fair bit >> of debugging world wide. >> >> Perhaps all this can still be avoided by adding further flags and >>

Re: [PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

On Wed, Jul 19, 2017 at 08:29:08PM +0530, Laxman Dewangan wrote: > >> Good that you found this and fixed it before someone git hurt. > > Well, while decoupling single-endedness from polarity was the right > > thing to do, this change did actually break the DT binary interface. > > > > If you have

Re: [PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

On Wed, Jul 19, 2017 at 08:29:08PM +0530, Laxman Dewangan wrote: > >> Good that you found this and fixed it before someone git hurt. > > Well, while decoupling single-endedness from polarity was the right > > thing to do, this change did actually break the DT binary interface. > > > > If you have

Re: [PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

On Wednesday 19 July 2017 06:55 PM, Johan Hovold wrote: On Fri, Apr 07, 2017 at 12:25:49PM +0200, Linus Walleij wrote: On Thu, Apr 6, 2017 at 3:35 PM, Laxman Dewangan wrote: Currently, the GPIO interface is said to Open Drain if it is Single Ended and active LOW.

Re: [PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

On Wednesday 19 July 2017 06:55 PM, Johan Hovold wrote: On Fri, Apr 07, 2017 at 12:25:49PM +0200, Linus Walleij wrote: On Thu, Apr 6, 2017 at 3:35 PM, Laxman Dewangan wrote: Currently, the GPIO interface is said to Open Drain if it is Single Ended and active LOW. Similarly, it is said as

Re: [PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

On Fri, Apr 07, 2017 at 12:25:49PM +0200, Linus Walleij wrote: > On Thu, Apr 6, 2017 at 3:35 PM, Laxman Dewangan wrote: > > > Currently, the GPIO interface is said to Open Drain if it is Single > > Ended and active LOW. Similarly, it is said as Open Source if it is > >

Re: [PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

On Fri, Apr 07, 2017 at 12:25:49PM +0200, Linus Walleij wrote: > On Thu, Apr 6, 2017 at 3:35 PM, Laxman Dewangan wrote: > > > Currently, the GPIO interface is said to Open Drain if it is Single > > Ended and active LOW. Similarly, it is said as Open Source if it is > > Single Ended and active

Re: [PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

On Friday 07 April 2017 03:55 PM, Linus Walleij wrote: On Thu, Apr 6, 2017 at 3:35 PM, Laxman Dewangan wrote: Currently, the GPIO interface is said to Open Drain if it is Single Ended and active LOW. Similarly, it is said as Open Source if it is Single Ended and active

Re: [PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

On Friday 07 April 2017 03:55 PM, Linus Walleij wrote: On Thu, Apr 6, 2017 at 3:35 PM, Laxman Dewangan wrote: Currently, the GPIO interface is said to Open Drain if it is Single Ended and active LOW. Similarly, it is said as Open Source if it is Single Ended and active HIGH. The active

Re: [PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

On Thu, Apr 6, 2017 at 3:35 PM, Laxman Dewangan wrote: > Currently, the GPIO interface is said to Open Drain if it is Single > Ended and active LOW. Similarly, it is said as Open Source if it is > Single Ended and active HIGH. > > The active HIGH/LOW is used in the

Re: [PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

On Thu, Apr 6, 2017 at 3:35 PM, Laxman Dewangan wrote: > Currently, the GPIO interface is said to Open Drain if it is Single > Ended and active LOW. Similarly, it is said as Open Source if it is > Single Ended and active HIGH. > > The active HIGH/LOW is used in the interface for setting the pin

Re: [PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

On Thu, Apr 6, 2017 at 7:56 PM, Laxman Dewangan wrote: > On Thursday 06 April 2017 09:40 PM, Andy Shevchenko wrote: >> On Thu, Apr 6, 2017 at 4:35 PM, Laxman Dewangan >> wrote: >>> Adding different flag for the Open Drain/Open Source which is valid

Re: [PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

On Thu, Apr 6, 2017 at 7:56 PM, Laxman Dewangan wrote: > On Thursday 06 April 2017 09:40 PM, Andy Shevchenko wrote: >> On Thu, Apr 6, 2017 at 4:35 PM, Laxman Dewangan >> wrote: >>> Adding different flag for the Open Drain/Open Source which is valid >>> only when Single ended flag is enabled.

Re: [PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

On Thursday 06 April 2017 09:40 PM, Andy Shevchenko wrote: On Thu, Apr 6, 2017 at 4:35 PM, Laxman Dewangan wrote: Currently, the GPIO interface is said to Open Drain if it is Single Ended and active LOW. Similarly, it is said as Open Source if it is Single Ended and

Re: [PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

On Thursday 06 April 2017 09:40 PM, Andy Shevchenko wrote: On Thu, Apr 6, 2017 at 4:35 PM, Laxman Dewangan wrote: Currently, the GPIO interface is said to Open Drain if it is Single Ended and active LOW. Similarly, it is said as Open Source if it is Single Ended and active HIGH. The active

Re: [PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

On Thu, Apr 6, 2017 at 4:35 PM, Laxman Dewangan wrote: > Currently, the GPIO interface is said to Open Drain if it is Single > Ended and active LOW. Similarly, it is said as Open Source if it is > Single Ended and active HIGH. > > The active HIGH/LOW is used in the interface

Re: [PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

On Thu, Apr 6, 2017 at 4:35 PM, Laxman Dewangan wrote: > Currently, the GPIO interface is said to Open Drain if it is Single > Ended and active LOW. Similarly, it is said as Open Source if it is > Single Ended and active HIGH. > > The active HIGH/LOW is used in the interface for setting the pin >

[PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

Currently, the GPIO interface is said to Open Drain if it is Single Ended and active LOW. Similarly, it is said as Open Source if it is Single Ended and active HIGH. The active HIGH/LOW is used in the interface for setting the pin state to HIGH or LOW when enabling/disabling the interface. In

[PATCH 1/1] gpio: core: Decouple open drain/source flag with active low/high

Currently, the GPIO interface is said to Open Drain if it is Single Ended and active LOW. Similarly, it is said as Open Source if it is Single Ended and active HIGH. The active HIGH/LOW is used in the interface for setting the pin state to HIGH or LOW when enabling/disabling the interface. In