Re: [PATCH 1/2] media: videobuf2: use dmabuf size for length

2021-03-26 Thread John Cox
Hi Helen >On 3/26/21 10:03 AM, John Cox wrote: >> Hi Helen >> >>> Hi John, >>> >>> On 3/25/21 7:20 AM, John Cox wrote: Hi > Always use dmabuf size when considering the length of the buffer. > Discard userspace provided length. > Fix length check error in _verify_length(),

Re: [PATCH 1/2] media: videobuf2: use dmabuf size for length

2021-03-26 Thread Helen Koike
On 3/26/21 10:03 AM, John Cox wrote: Hi Helen Hi John, On 3/25/21 7:20 AM, John Cox wrote: Hi Always use dmabuf size when considering the length of the buffer. Discard userspace provided length. Fix length check error in _verify_length(), which was handling single and multiplanar

Re: [PATCH 1/2] media: videobuf2: use dmabuf size for length

2021-03-26 Thread John Cox
Hi Helen >Hi John, > >On 3/25/21 7:20 AM, John Cox wrote: >> Hi >> >>> Always use dmabuf size when considering the length of the buffer. >>> Discard userspace provided length. >>> Fix length check error in _verify_length(), which was handling single and >>> multiplanar diferently, and also not

Re: [PATCH 1/2] media: videobuf2: use dmabuf size for length

2021-03-26 Thread Helen Koike
Hi Laurent, On 3/25/21 7:53 AM, Laurent Pinchart wrote: Hi Helen, On Wed, Mar 24, 2021 at 09:17:11PM -0300, Helen Koike wrote: Always use dmabuf size when considering the length of the buffer. Discard userspace provided length. Fix length check error in _verify_length(), which was handling

Re: [PATCH 1/2] media: videobuf2: use dmabuf size for length

2021-03-26 Thread Helen Koike
Hi John, On 3/25/21 7:20 AM, John Cox wrote: Hi Always use dmabuf size when considering the length of the buffer. Discard userspace provided length. Fix length check error in _verify_length(), which was handling single and multiplanar diferently, and also not catching the case where userspace

Re: [PATCH 1/2] media: videobuf2: use dmabuf size for length

2021-03-25 Thread Laurent Pinchart
Hi Helen, On Wed, Mar 24, 2021 at 09:17:11PM -0300, Helen Koike wrote: > Always use dmabuf size when considering the length of the buffer. > Discard userspace provided length. > Fix length check error in _verify_length(), which was handling single and > multiplanar diferently, and also not

Re: [PATCH 1/2] media: videobuf2: use dmabuf size for length

2021-03-25 Thread John Cox
Hi >Always use dmabuf size when considering the length of the buffer. >Discard userspace provided length. >Fix length check error in _verify_length(), which was handling single and >multiplanar diferently, and also not catching the case where userspace >provides a bigger length and bytesused then

[PATCH 1/2] media: videobuf2: use dmabuf size for length

2021-03-24 Thread Helen Koike
Always use dmabuf size when considering the length of the buffer. Discard userspace provided length. Fix length check error in _verify_length(), which was handling single and multiplanar diferently, and also not catching the case where userspace provides a bigger length and bytesused then the