Re: [PATCH 1/2] pinctrl: sh-pfc: enable to indicate GPSR/IPSR/MOD_SEL for debug

Hi Laurent, Geert > > struct pinmux_cfg_reg { > > + const char *name; > > This will increase the kernel size, I would remove the name field when > compiling the kernel in non-debug mode. You could use CONFIG_DYNAMIC_DEBUG or > CONFIG_DEBUG_PINCTRL. OK, [1/2] patch is not a big deal. I'm

Re: [PATCH 1/2] pinctrl: sh-pfc: enable to indicate GPSR/IPSR/MOD_SEL for debug

Hi Laurent, Geert > > struct pinmux_cfg_reg { > > + const char *name; > > This will increase the kernel size, I would remove the name field when > compiling the kernel in non-debug mode. You could use CONFIG_DYNAMIC_DEBUG or > CONFIG_DEBUG_PINCTRL. OK, [1/2] patch is not a big deal. I'm

Re: [PATCH 1/2] pinctrl: sh-pfc: enable to indicate GPSR/IPSR/MOD_SEL for debug

Hi Geert > > From: Kuninori Morimoto > > > > Current sh_pfc can't indicate GPSR/IPSR/MOD_SEL name for debug. > > Of course we can get it from indicated register address, but it > > is not convenient. This patch enables to indicate these. > > > > Signed-off-by:

Re: [PATCH 1/2] pinctrl: sh-pfc: enable to indicate GPSR/IPSR/MOD_SEL for debug

Hi Geert > > From: Kuninori Morimoto > > > > Current sh_pfc can't indicate GPSR/IPSR/MOD_SEL name for debug. > > Of course we can get it from indicated register address, but it > > is not convenient. This patch enables to indicate these. > > > > Signed-off-by: Kuninori Morimoto > > > ---

Re: [PATCH 1/2] pinctrl: sh-pfc: enable to indicate GPSR/IPSR/MOD_SEL for debug

Hi Morimoto-san, On Thu, Mar 17, 2016 at 1:30 AM, Kuninori Morimoto wrote: >> > From: Kuninori Morimoto >> > >> > Current sh_pfc can't indicate GPSR/IPSR/MOD_SEL name for debug. >> > Of course we can get it from indicated

Re: [PATCH 1/2] pinctrl: sh-pfc: enable to indicate GPSR/IPSR/MOD_SEL for debug

Hi Morimoto-san, On Thu, Mar 17, 2016 at 1:30 AM, Kuninori Morimoto wrote: >> > From: Kuninori Morimoto >> > >> > Current sh_pfc can't indicate GPSR/IPSR/MOD_SEL name for debug. >> > Of course we can get it from indicated register address, but it >> > is not convenient. This patch enables to

Re: [PATCH 1/2] pinctrl: sh-pfc: enable to indicate GPSR/IPSR/MOD_SEL for debug

Hi Morimoto-san, Thank you for the patch. On Wednesday 16 March 2016 00:47:48 Kuninori Morimoto wrote: > From: Kuninori Morimoto > > Current sh_pfc can't indicate GPSR/IPSR/MOD_SEL name for debug. > Of course we can get it from indicated register address, but

Re: [PATCH 1/2] pinctrl: sh-pfc: enable to indicate GPSR/IPSR/MOD_SEL for debug

Hi Morimoto-san, Thank you for the patch. On Wednesday 16 March 2016 00:47:48 Kuninori Morimoto wrote: > From: Kuninori Morimoto > > Current sh_pfc can't indicate GPSR/IPSR/MOD_SEL name for debug. > Of course we can get it from indicated register address, but it > is not convenient. This patch

Re: [PATCH 1/2] pinctrl: sh-pfc: enable to indicate GPSR/IPSR/MOD_SEL for debug

Hi Morimoto-san, On Wed, Mar 16, 2016 at 1:47 AM, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > Current sh_pfc can't indicate GPSR/IPSR/MOD_SEL name for debug. > Of course we can get it from indicated register address,

Re: [PATCH 1/2] pinctrl: sh-pfc: enable to indicate GPSR/IPSR/MOD_SEL for debug

Hi Morimoto-san, On Wed, Mar 16, 2016 at 1:47 AM, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > Current sh_pfc can't indicate GPSR/IPSR/MOD_SEL name for debug. > Of course we can get it from indicated register address, but it > is not convenient. This patch enables to indicate these. >

[PATCH 1/2] pinctrl: sh-pfc: enable to indicate GPSR/IPSR/MOD_SEL for debug

From: Kuninori Morimoto Current sh_pfc can't indicate GPSR/IPSR/MOD_SEL name for debug. Of course we can get it from indicated register address, but it is not convenient. This patch enables to indicate these. Signed-off-by: Kuninori Morimoto

[PATCH 1/2] pinctrl: sh-pfc: enable to indicate GPSR/IPSR/MOD_SEL for debug

From: Kuninori Morimoto Current sh_pfc can't indicate GPSR/IPSR/MOD_SEL name for debug. Of course we can get it from indicated register address, but it is not convenient. This patch enables to indicate these. Signed-off-by: Kuninori Morimoto --- drivers/pinctrl/sh-pfc/core.c | 3 ++-