Re: [PATCH 1/3] perf sched map: Apply cpu color when there's an activity

2016-10-25 Thread Namhyung Kim
Hi Arnaldo, On Tue, Oct 25, 2016 at 03:07:46PM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Oct 24, 2016 at 11:02:43AM +0900, Namhyung Kim escreveu: > > Applying cpu color always doesn't help readability IMHO. Instead it > > might be better to applying the color when there's an activity on

Re: [PATCH 1/3] perf sched map: Apply cpu color when there's an activity

2016-10-25 Thread Namhyung Kim
Hi Arnaldo, On Tue, Oct 25, 2016 at 03:07:46PM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Oct 24, 2016 at 11:02:43AM +0900, Namhyung Kim escreveu: > > Applying cpu color always doesn't help readability IMHO. Instead it > > might be better to applying the color when there's an activity on

Re: [PATCH 1/3] perf sched map: Apply cpu color when there's an activity

2016-10-25 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 24, 2016 at 11:02:43AM +0900, Namhyung Kim escreveu: > Applying cpu color always doesn't help readability IMHO. Instead it > might be better to applying the color when there's an activity on those > CPUs. thanks, applied the three patches. - Arnaldo > Cc: Jiri Olsa

Re: [PATCH 1/3] perf sched map: Apply cpu color when there's an activity

2016-10-25 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 24, 2016 at 11:02:43AM +0900, Namhyung Kim escreveu: > Applying cpu color always doesn't help readability IMHO. Instead it > might be better to applying the color when there's an activity on those > CPUs. thanks, applied the three patches. - Arnaldo > Cc: Jiri Olsa >

Re: [PATCH 1/3] perf sched map: Apply cpu color when there's an activity

2016-10-24 Thread Jiri Olsa
On Mon, Oct 24, 2016 at 11:02:43AM +0900, Namhyung Kim wrote: > Applying cpu color always doesn't help readability IMHO. Instead it > might be better to applying the color when there's an activity on those > CPUs. ok, I added it to easily spot cpu columns I was interested in, but I think I can

Re: [PATCH 1/3] perf sched map: Apply cpu color when there's an activity

2016-10-24 Thread Jiri Olsa
On Mon, Oct 24, 2016 at 11:02:43AM +0900, Namhyung Kim wrote: > Applying cpu color always doesn't help readability IMHO. Instead it > might be better to applying the color when there's an activity on those > CPUs. ok, I added it to easily spot cpu columns I was interested in, but I think I can

[PATCH 1/3] perf sched map: Apply cpu color when there's an activity

2016-10-23 Thread Namhyung Kim
Applying cpu color always doesn't help readability IMHO. Instead it might be better to applying the color when there's an activity on those CPUs. Cc: Jiri Olsa Signed-off-by: Namhyung Kim --- tools/perf/builtin-sched.c | 2 +- 1 file changed, 1

[PATCH 1/3] perf sched map: Apply cpu color when there's an activity

2016-10-23 Thread Namhyung Kim
Applying cpu color always doesn't help readability IMHO. Instead it might be better to applying the color when there's an activity on those CPUs. Cc: Jiri Olsa Signed-off-by: Namhyung Kim --- tools/perf/builtin-sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git