Re: [PATCH 1/3] x86/intel_rdt: Fix issue when mkdir uses a freed CLOSid

2017-04-11 Thread Shivappa Vikas
On Mon, 10 Apr 2017, Thomas Gleixner wrote: On Wed, 5 Apr 2017, Luck, Tony wrote: On Wed, Apr 05, 2017 at 05:20:24PM +0200, Thomas Gleixner wrote: That's just wrong. The proper behaviour for a new control group is, that at the time when it is created it copies the CBM values of the default

Re: [PATCH 1/3] x86/intel_rdt: Fix issue when mkdir uses a freed CLOSid

2017-04-11 Thread Shivappa Vikas
On Mon, 10 Apr 2017, Thomas Gleixner wrote: On Wed, 5 Apr 2017, Luck, Tony wrote: On Wed, Apr 05, 2017 at 05:20:24PM +0200, Thomas Gleixner wrote: That's just wrong. The proper behaviour for a new control group is, that at the time when it is created it copies the CBM values of the default

Re: [PATCH 1/3] x86/intel_rdt: Fix issue when mkdir uses a freed CLOSid

2017-04-10 Thread Thomas Gleixner
On Wed, 5 Apr 2017, Luck, Tony wrote: > On Wed, Apr 05, 2017 at 05:20:24PM +0200, Thomas Gleixner wrote: > > That's just wrong. > > > > The proper behaviour for a new control group is, that at the time when it > > is created it copies the CBM values of the default group and not claiming > >

Re: [PATCH 1/3] x86/intel_rdt: Fix issue when mkdir uses a freed CLOSid

2017-04-10 Thread Thomas Gleixner
On Wed, 5 Apr 2017, Luck, Tony wrote: > On Wed, Apr 05, 2017 at 05:20:24PM +0200, Thomas Gleixner wrote: > > That's just wrong. > > > > The proper behaviour for a new control group is, that at the time when it > > is created it copies the CBM values of the default group and not claiming > >

Re: [PATCH 1/3] x86/intel_rdt: Fix issue when mkdir uses a freed CLOSid

2017-04-05 Thread Fenghua Yu
On Wed, Apr 05, 2017 at 11:07:37AM -0700, Luck, Tony wrote: > On Wed, Apr 05, 2017 at 05:20:24PM +0200, Thomas Gleixner wrote: > > That's just wrong. > > > > The proper behaviour for a new control group is, that at the time when it > > is created it copies the CBM values of the default group and

Re: [PATCH 1/3] x86/intel_rdt: Fix issue when mkdir uses a freed CLOSid

2017-04-05 Thread Fenghua Yu
On Wed, Apr 05, 2017 at 11:07:37AM -0700, Luck, Tony wrote: > On Wed, Apr 05, 2017 at 05:20:24PM +0200, Thomas Gleixner wrote: > > That's just wrong. > > > > The proper behaviour for a new control group is, that at the time when it > > is created it copies the CBM values of the default group and

Re: [PATCH 1/3] x86/intel_rdt: Fix issue when mkdir uses a freed CLOSid

2017-04-05 Thread Luck, Tony
On Wed, Apr 05, 2017 at 05:20:24PM +0200, Thomas Gleixner wrote: > That's just wrong. > > The proper behaviour for a new control group is, that at the time when it > is created it copies the CBM values of the default group and not claiming > access to ALL of the cache by default. I don't see

Re: [PATCH 1/3] x86/intel_rdt: Fix issue when mkdir uses a freed CLOSid

2017-04-05 Thread Luck, Tony
On Wed, Apr 05, 2017 at 05:20:24PM +0200, Thomas Gleixner wrote: > That's just wrong. > > The proper behaviour for a new control group is, that at the time when it > is created it copies the CBM values of the default group and not claiming > access to ALL of the cache by default. I don't see

Re: [PATCH 1/3] x86/intel_rdt: Fix issue when mkdir uses a freed CLOSid

2017-04-05 Thread Shivappa Vikas
On Wed, 5 Apr 2017, Thomas Gleixner wrote: On Mon, 3 Apr 2017, Vikas Shivappa wrote: Subject: x86/intel_rdt: Fix issue when mkdir uses a freed CLOSid This subject line is useless again. It want's to be descriptive. "Fix issue" Which issue? Each resctrl directory has one CLOSid

Re: [PATCH 1/3] x86/intel_rdt: Fix issue when mkdir uses a freed CLOSid

2017-04-05 Thread Shivappa Vikas
On Wed, 5 Apr 2017, Thomas Gleixner wrote: On Mon, 3 Apr 2017, Vikas Shivappa wrote: Subject: x86/intel_rdt: Fix issue when mkdir uses a freed CLOSid This subject line is useless again. It want's to be descriptive. "Fix issue" Which issue? Each resctrl directory has one CLOSid

Re: [PATCH 1/3] x86/intel_rdt: Fix issue when mkdir uses a freed CLOSid

2017-04-05 Thread Thomas Gleixner
On Mon, 3 Apr 2017, Vikas Shivappa wrote: > Subject: x86/intel_rdt: Fix issue when mkdir uses a freed CLOSid This subject line is useless again. It want's to be descriptive. "Fix issue" Which issue? > Each resctrl directory has one CLOSid allocated which is mapped to a > control

Re: [PATCH 1/3] x86/intel_rdt: Fix issue when mkdir uses a freed CLOSid

2017-04-05 Thread Thomas Gleixner
On Mon, 3 Apr 2017, Vikas Shivappa wrote: > Subject: x86/intel_rdt: Fix issue when mkdir uses a freed CLOSid This subject line is useless again. It want's to be descriptive. "Fix issue" Which issue? > Each resctrl directory has one CLOSid allocated which is mapped to a > control

[PATCH 1/3] x86/intel_rdt: Fix issue when mkdir uses a freed CLOSid

2017-04-03 Thread Vikas Shivappa
Each resctrl directory has one CLOSid allocated which is mapped to a control register/QOS_MSR. During an rmdir this CLOSid is freed and can be reused later when a new directory is created. Currently we do not reset the QOS_MSR to a default when the CLOSid is freed. So when the next mkdir uses a

[PATCH 1/3] x86/intel_rdt: Fix issue when mkdir uses a freed CLOSid

2017-04-03 Thread Vikas Shivappa
Each resctrl directory has one CLOSid allocated which is mapped to a control register/QOS_MSR. During an rmdir this CLOSid is freed and can be reused later when a new directory is created. Currently we do not reset the QOS_MSR to a default when the CLOSid is freed. So when the next mkdir uses a