Re: [PATCH 1/6] regulator: core: Allow simultaneous use of enable op and GPIO

2016-06-23 Thread Mark Brown
On Thu, Jun 23, 2016 at 02:29:39PM +0900, Alexandre Courbot wrote: > There is also another potential problem with not using the enable GPIO > in the regulator core: said GPIO can not be shared anymore between > several regulators, as this was handled by the core. Yeah, but there's more fun there

Re: [PATCH 1/6] regulator: core: Allow simultaneous use of enable op and GPIO

2016-06-23 Thread Mark Brown
On Thu, Jun 23, 2016 at 02:29:39PM +0900, Alexandre Courbot wrote: > There is also another potential problem with not using the enable GPIO > in the regulator core: said GPIO can not be shared anymore between > several regulators, as this was handled by the core. Yeah, but there's more fun there

Re: [PATCH 1/6] regulator: core: Allow simultaneous use of enable op and GPIO

2016-06-22 Thread Alexandre Courbot
On Thu, Jun 23, 2016 at 10:10 AM, Alexandre Courbot wrote: > On Wed, Jun 22, 2016 at 7:34 PM, Mark Brown wrote: >> On Wed, Jun 22, 2016 at 05:25:53PM +0900, Alexandre Courbot wrote: >>> The current regulator enable/disable mechanism does not call the driver

Re: [PATCH 1/6] regulator: core: Allow simultaneous use of enable op and GPIO

2016-06-22 Thread Alexandre Courbot
On Thu, Jun 23, 2016 at 10:10 AM, Alexandre Courbot wrote: > On Wed, Jun 22, 2016 at 7:34 PM, Mark Brown wrote: >> On Wed, Jun 22, 2016 at 05:25:53PM +0900, Alexandre Courbot wrote: >>> The current regulator enable/disable mechanism does not call the driver >>> enable/disable op if an enable

Re: [PATCH 1/6] regulator: core: Allow simultaneous use of enable op and GPIO

2016-06-22 Thread Alexandre Courbot
On Wed, Jun 22, 2016 at 7:34 PM, Mark Brown wrote: > On Wed, Jun 22, 2016 at 05:25:53PM +0900, Alexandre Courbot wrote: >> The current regulator enable/disable mechanism does not call the driver >> enable/disable op if an enable GPIO is set. It may be desirable to use >> both

Re: [PATCH 1/6] regulator: core: Allow simultaneous use of enable op and GPIO

2016-06-22 Thread Alexandre Courbot
On Wed, Jun 22, 2016 at 7:34 PM, Mark Brown wrote: > On Wed, Jun 22, 2016 at 05:25:53PM +0900, Alexandre Courbot wrote: >> The current regulator enable/disable mechanism does not call the driver >> enable/disable op if an enable GPIO is set. It may be desirable to use >> both mechanisms though,

Re: [PATCH 1/6] regulator: core: Allow simultaneous use of enable op and GPIO

2016-06-22 Thread Mark Brown
On Wed, Jun 22, 2016 at 05:25:53PM +0900, Alexandre Courbot wrote: > The current regulator enable/disable mechanism does not call the driver > enable/disable op if an enable GPIO is set. It may be desirable to use > both mechanisms though, e.g. in the case of a PWM regulator that also > has an

Re: [PATCH 1/6] regulator: core: Allow simultaneous use of enable op and GPIO

2016-06-22 Thread Mark Brown
On Wed, Jun 22, 2016 at 05:25:53PM +0900, Alexandre Courbot wrote: > The current regulator enable/disable mechanism does not call the driver > enable/disable op if an enable GPIO is set. It may be desirable to use > both mechanisms though, e.g. in the case of a PWM regulator that also > has an

[PATCH 1/6] regulator: core: Allow simultaneous use of enable op and GPIO

2016-06-22 Thread Alexandre Courbot
The current regulator enable/disable mechanism does not call the driver enable/disable op if an enable GPIO is set. It may be desirable to use both mechanisms though, e.g. in the case of a PWM regulator that also has an enable GPIO. _regulator_is_enabled() is also updated in order to take both

[PATCH 1/6] regulator: core: Allow simultaneous use of enable op and GPIO

2016-06-22 Thread Alexandre Courbot
The current regulator enable/disable mechanism does not call the driver enable/disable op if an enable GPIO is set. It may be desirable to use both mechanisms though, e.g. in the case of a PWM regulator that also has an enable GPIO. _regulator_is_enabled() is also updated in order to take both