Re: [PATCH 1/7] mm: memcontrol: fix page charging in page replacement

2021-04-14 Thread Michal Hocko
On Tue 13-04-21 14:51:47, Muchun Song wrote: > The pages aren't accounted at the root level, so do not charge the page > to the root memcg in page replacement. Although we do not display the > value (mem_cgroup_usage) so there shouldn't be any actual problem, but > there is a WARN_ON_ONCE in the

Re: [PATCH 1/7] mm: memcontrol: fix page charging in page replacement

2021-04-13 Thread Roman Gushchin
On Tue, Apr 13, 2021 at 02:51:47PM +0800, Muchun Song wrote: > The pages aren't accounted at the root level, so do not charge the page > to the root memcg in page replacement. Although we do not display the > value (mem_cgroup_usage) so there shouldn't be any actual problem, but > there is a

[PATCH 1/7] mm: memcontrol: fix page charging in page replacement

2021-04-13 Thread Muchun Song
The pages aren't accounted at the root level, so do not charge the page to the root memcg in page replacement. Although we do not display the value (mem_cgroup_usage) so there shouldn't be any actual problem, but there is a WARN_ON_ONCE in the page_counter_cancel(). Who knows if it will trigger?