Re: [PATCH 1/9] um/drivers/vector_user: Delete unnecessary code in user_init_raw_fds()

Thanks, well noted. It still does not fix it completely though. Re-reading the code it will leak a fd if the malloc for result fails. That return result; there should be inside the conditional falling back to cleanup if the alloc fails. A. On 03/11/18 15:16, SF Markus Elfring wrote:

Re: [PATCH 1/9] um/drivers/vector_user: Delete unnecessary code in user_init_raw_fds()

Thanks, well noted. It still does not fix it completely though. Re-reading the code it will leak a fd if the malloc for result fails. That return result; there should be inside the conditional falling back to cleanup if the alloc fails. A. On 03/11/18 15:16, SF Markus Elfring wrote:

[PATCH 1/9] um/drivers/vector_user: Delete unnecessary code in user_init_raw_fds()

From: Markus Elfring Date: Sun, 11 Mar 2018 11:36:18 +0100 * One condition check could never be reached with a non-null pointer at the end of this function. Thus remove the corresponding statement. * Delete an initialisation for the local variable "result"

[PATCH 1/9] um/drivers/vector_user: Delete unnecessary code in user_init_raw_fds()

From: Markus Elfring Date: Sun, 11 Mar 2018 11:36:18 +0100 * One condition check could never be reached with a non-null pointer at the end of this function. Thus remove the corresponding statement. * Delete an initialisation for the local variable "result" which became unnecessary with this