Re: [PATCH 10/10] Bluetooth: add nokia driver

Hi! > +struct hci_nokia_neg_hdr { > + __u8dlen; > +} __packed; > + > +struct hci_nokia_neg_cmd { > + __u8ack; > + __u16 baud; > + __u16 unused1; > + __u8proto; > + __u16 sys_clk; > + __u16 unused2; > +} __packed; __u8 -> u8? This is not exported to

Re: [PATCH 10/10] Bluetooth: add nokia driver

Hi! > +struct hci_nokia_neg_hdr { > + __u8dlen; > +} __packed; > + > +struct hci_nokia_neg_cmd { > + __u8ack; > + __u16 baud; > + __u16 unused1; > + __u8proto; > + __u16 sys_clk; > + __u16 unused2; > +} __packed; __u8 -> u8? This is not exported to

Re: [PATCH 10/10] Bluetooth: add nokia driver

On Tue, Mar 7, 2017 at 3:08 PM, Sebastian Reichel wrote: > Hi Rob, > > On Tue, Mar 07, 2017 at 10:30:51AM -0600, Rob Herring wrote: >> On Sat, Mar 4, 2017 at 5:58 AM, Sebastian Reichel wrote: >> > This adds a driver for the Nokia H4+ protocol, which is used >> >

Re: [PATCH 10/10] Bluetooth: add nokia driver

On Tue, Mar 7, 2017 at 3:08 PM, Sebastian Reichel wrote: > Hi Rob, > > On Tue, Mar 07, 2017 at 10:30:51AM -0600, Rob Herring wrote: >> On Sat, Mar 4, 2017 at 5:58 AM, Sebastian Reichel wrote: >> > This adds a driver for the Nokia H4+ protocol, which is used >> > at least on the Nokia N9, N900 &

Re: [PATCH 10/10] Bluetooth: add nokia driver

Hi Marcel, On Tue, Mar 07, 2017 at 10:20:27PM +0100, Marcel Holtmann wrote: >> [...] >> >> - compatible: should contain "nokia,h4p-bluetooth" as well as one of the >> following: >> * "brcm,bcm2048-nokia" >> * "ti,wl1271-blueooth-nokia” > > I never liked the term “h4p”. It is fundamentally just

Re: [PATCH 10/10] Bluetooth: add nokia driver

Hi Marcel, On Tue, Mar 07, 2017 at 10:20:27PM +0100, Marcel Holtmann wrote: >> [...] >> >> - compatible: should contain "nokia,h4p-bluetooth" as well as one of the >> following: >> * "brcm,bcm2048-nokia" >> * "ti,wl1271-blueooth-nokia” > > I never liked the term “h4p”. It is fundamentally just

Re: [PATCH 10/10] Bluetooth: add nokia driver

Hi Sebastian, >>> This adds a driver for the Nokia H4+ protocol, which is used >>> at least on the Nokia N9, N900 & N950. >>> >>> Signed-off-by: Sebastian Reichel >>> --- >>> .../devicetree/bindings/net/nokia-bluetooth.txt| 51 ++ >> >> This should be separate and before

Re: [PATCH 10/10] Bluetooth: add nokia driver

Hi Sebastian, >>> This adds a driver for the Nokia H4+ protocol, which is used >>> at least on the Nokia N9, N900 & N950. >>> >>> Signed-off-by: Sebastian Reichel >>> --- >>> .../devicetree/bindings/net/nokia-bluetooth.txt| 51 ++ >> >> This should be separate and before the dts files. >>

Re: [PATCH 10/10] Bluetooth: add nokia driver

Hi Rob, On Tue, Mar 07, 2017 at 10:30:51AM -0600, Rob Herring wrote: > On Sat, Mar 4, 2017 at 5:58 AM, Sebastian Reichel wrote: > > This adds a driver for the Nokia H4+ protocol, which is used > > at least on the Nokia N9, N900 & N950. > > > > Signed-off-by: Sebastian Reichel

Re: [PATCH 10/10] Bluetooth: add nokia driver

Hi Rob, On Tue, Mar 07, 2017 at 10:30:51AM -0600, Rob Herring wrote: > On Sat, Mar 4, 2017 at 5:58 AM, Sebastian Reichel wrote: > > This adds a driver for the Nokia H4+ protocol, which is used > > at least on the Nokia N9, N900 & N950. > > > > Signed-off-by: Sebastian Reichel > > --- > >

Re: [PATCH 10/10] Bluetooth: add nokia driver

On Sat, Mar 4, 2017 at 5:58 AM, Sebastian Reichel wrote: > This adds a driver for the Nokia H4+ protocol, which is used > at least on the Nokia N9, N900 & N950. > > Signed-off-by: Sebastian Reichel > --- > .../devicetree/bindings/net/nokia-bluetooth.txt|

Re: [PATCH 10/10] Bluetooth: add nokia driver

On Sat, Mar 4, 2017 at 5:58 AM, Sebastian Reichel wrote: > This adds a driver for the Nokia H4+ protocol, which is used > at least on the Nokia N9, N900 & N950. > > Signed-off-by: Sebastian Reichel > --- > .../devicetree/bindings/net/nokia-bluetooth.txt| 51 ++ This should be separate and

[PATCH 10/10] Bluetooth: add nokia driver

This adds a driver for the Nokia H4+ protocol, which is used at least on the Nokia N9, N900 & N950. Signed-off-by: Sebastian Reichel --- .../devicetree/bindings/net/nokia-bluetooth.txt| 51 ++ drivers/bluetooth/Kconfig | 12 +

[PATCH 10/10] Bluetooth: add nokia driver

This adds a driver for the Nokia H4+ protocol, which is used at least on the Nokia N9, N900 & N950. Signed-off-by: Sebastian Reichel --- .../devicetree/bindings/net/nokia-bluetooth.txt| 51 ++ drivers/bluetooth/Kconfig | 12 + drivers/bluetooth/Makefile