Re: [PATCH 10/24] elevate write count during entire ncp_ioctl()

2007-09-19 Thread Christoph Hellwig
On Mon, Sep 17, 2007 at 11:27:31AM -0700, Dave Hansen wrote: > > Some ioctls need write access, but others don't. Make a helper > function to decide when write access is needed, and take it. The WARN_ON is too agressive because it'll happen whenever someone tries a random, non-existant ioctl on

Re: [PATCH 10/24] elevate write count during entire ncp_ioctl()

2007-09-19 Thread Christoph Hellwig
On Mon, Sep 17, 2007 at 11:27:31AM -0700, Dave Hansen wrote: Some ioctls need write access, but others don't. Make a helper function to decide when write access is needed, and take it. The WARN_ON is too agressive because it'll happen whenever someone tries a random, non-existant ioctl on

[PATCH 10/24] elevate write count during entire ncp_ioctl()

2007-09-17 Thread Dave Hansen
Some ioctls need write access, but others don't. Make a helper function to decide when write access is needed, and take it. Signed-off-by: Dave Hansen <[EMAIL PROTECTED]> --- lxc-dave/fs/ncpfs/ioctl.c | 55 +- 1 file changed, 54 insertions(+), 1

[PATCH 10/24] elevate write count during entire ncp_ioctl()

2007-09-17 Thread Dave Hansen
Some ioctls need write access, but others don't. Make a helper function to decide when write access is needed, and take it. Signed-off-by: Dave Hansen [EMAIL PROTECTED] --- lxc-dave/fs/ncpfs/ioctl.c | 55 +- 1 file changed, 54 insertions(+), 1