Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

在 2016/5/12 5:42, Doug Anderson 写道: Shawn, On Wed, May 11, 2016 at 1:25 AM, Shawn Lin wrote: On 2016/5/11 11:50, Doug Anderson wrote: Hi, On Tue, May 10, 2016 at 7:50 PM, Shawn Lin wrote: maybe. But I think 180(downside) is the better.

Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

在 2016/5/12 5:42, Doug Anderson 写道: Shawn, On Wed, May 11, 2016 at 1:25 AM, Shawn Lin wrote: On 2016/5/11 11:50, Doug Anderson wrote: Hi, On Tue, May 10, 2016 at 7:50 PM, Shawn Lin wrote: maybe. But I think 180(downside) is the better. NAK my previous comments here. Downside is

Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

Shawn, On Wed, May 11, 2016 at 1:25 AM, Shawn Lin wrote: > On 2016/5/11 11:50, Doug Anderson wrote: >> >> Hi, >> >> On Tue, May 10, 2016 at 7:50 PM, Shawn Lin >> wrote: > > maybe. But I think 180(downside) is the better. >>> >>> >>>

Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

Shawn, On Wed, May 11, 2016 at 1:25 AM, Shawn Lin wrote: > On 2016/5/11 11:50, Doug Anderson wrote: >> >> Hi, >> >> On Tue, May 10, 2016 at 7:50 PM, Shawn Lin >> wrote: > > maybe. But I think 180(downside) is the better. >>> >>> >>> >>> NAK my previous comments here. Downside is better

Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

On 2016/5/11 11:50, Doug Anderson wrote: Hi, On Tue, May 10, 2016 at 7:50 PM, Shawn Lin wrote: maybe. But I think 180(downside) is the better. NAK my previous comments here. Downside is better for SRD, but won't work for DDR mode. When running in DDR mode, we

Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

On 2016/5/11 11:50, Doug Anderson wrote: Hi, On Tue, May 10, 2016 at 7:50 PM, Shawn Lin wrote: maybe. But I think 180(downside) is the better. NAK my previous comments here. Downside is better for SRD, but won't work for DDR mode. When running in DDR mode, we should use 90 instead. So let

Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

Hi, On Tue, May 10, 2016 at 7:50 PM, Shawn Lin wrote: >>> maybe. But I think 180(downside) is the better. > > > NAK my previous comments here. Downside is better for SRD, but won't > work for DDR mode. When running in DDR mode, we should use 90 instead. > > So let me

Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

Hi, On Tue, May 10, 2016 at 7:50 PM, Shawn Lin wrote: >>> maybe. But I think 180(downside) is the better. > > > NAK my previous comments here. Downside is better for SRD, but won't > work for DDR mode. When running in DDR mode, we should use 90 instead. > > So let me elaborate a bit more here. >

Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

On 2016/5/10 23:57, Doug Anderson wrote: (again, but not HTML) --8<-- I have less faith than you in the TRM. The TRM is full of minor errors and is often wrong about the default state of things. IMHO the only true way to find out is to boot up some SoCs and check.

Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

On 2016/5/10 23:57, Doug Anderson wrote: (again, but not HTML) --8<-- I have less faith than you in the TRM. The TRM is full of minor errors and is often wrong about the default state of things. IMHO the only true way to find out is to boot up some SoCs and check.

Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

(again, but not HTML) On Tue, May 10, 2016 at 3:19 AM, Shawn Lin wrote: > 在 2016/5/10 0:31, Doug Anderson 写道: >> >> Hi, >> >> On Mon, May 9, 2016 at 4:12 AM, Shawn Lin >> wrote: 1. Specifying a single number for this property in

Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

(again, but not HTML) On Tue, May 10, 2016 at 3:19 AM, Shawn Lin wrote: > 在 2016/5/10 0:31, Doug Anderson 写道: >> >> Hi, >> >> On Mon, May 9, 2016 at 4:12 AM, Shawn Lin >> wrote: 1. Specifying a single number for this property in terms of "degrees" is probably not right. The

Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

在 2016/5/10 0:31, Doug Anderson 写道: Hi, On Mon, May 9, 2016 at 4:12 AM, Shawn Lin wrote: 1. Specifying a single number for this property in terms of "degrees" is probably not right. The whole point of setting the "drive phase" is to meet hold times, which are

Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

在 2016/5/10 0:31, Doug Anderson 写道: Hi, On Mon, May 9, 2016 at 4:12 AM, Shawn Lin wrote: 1. Specifying a single number for this property in terms of "degrees" is probably not right. The whole point of setting the "drive phase" is to meet hold times, which are specified in the spec in terms

Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

Hi, On Mon, May 9, 2016 at 4:12 AM, Shawn Lin wrote: >> 1. Specifying a single number for this property in terms of "degrees" >> is probably not right. The whole point of setting the "drive phase" >> is to meet hold times, which are specified in the spec in terms of ns

Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

Hi, On Mon, May 9, 2016 at 4:12 AM, Shawn Lin wrote: >> 1. Specifying a single number for this property in terms of "degrees" >> is probably not right. The whole point of setting the "drive phase" >> is to meet hold times, which are specified in the spec in terms of ns >> in the spec and also

Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

On 2016/5/7 1:26, Doug Anderson wrote: Shawn, On Fri, May 6, 2016 at 2:41 AM, Shawn Lin wrote: rockchip,default-drv-phase is used to set the default drv degrees. drv phases will decide the write timing of mmc controller. Device tree bindings should probably have

Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

On 2016/5/7 1:26, Doug Anderson wrote: Shawn, On Fri, May 6, 2016 at 2:41 AM, Shawn Lin wrote: rockchip,default-drv-phase is used to set the default drv degrees. drv phases will decide the write timing of mmc controller. Device tree bindings should probably have been patch 1/2, then the

Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

Shawn, On Fri, May 6, 2016 at 2:41 AM, Shawn Lin wrote: > rockchip,default-drv-phase is used to set the default drv degrees. > drv phases will decide the write timing of mmc controller. Device tree bindings should probably have been patch 1/2, then the code patch 2/2.

Re: [PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

Shawn, On Fri, May 6, 2016 at 2:41 AM, Shawn Lin wrote: > rockchip,default-drv-phase is used to set the default drv degrees. > drv phases will decide the write timing of mmc controller. Device tree bindings should probably have been patch 1/2, then the code patch 2/2. > Signed-off-by: Shawn

[PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

rockchip,default-drv-phase is used to set the default drv degrees. drv phases will decide the write timing of mmc controller. Signed-off-by: Shawn Lin --- Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 2/2] dt-bindings: rockchip-dw-mshc: add rockchip,default-drv-phase

rockchip,default-drv-phase is used to set the default drv degrees. drv phases will decide the write timing of mmc controller. Signed-off-by: Shawn Lin --- Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git