Re: [PATCH 2/2] streamline_config.pl: Add softtabstop=4 for vim users

2021-03-26 Thread Joe Perches
On Thu, 2021-03-25 at 09:50 -0400, Steven Rostedt wrote: > On Thu, 25 Mar 2021 15:20:13 +0900 Masahiro Yamada > wrote: > > > > The root cause of inconsistency is that > > you mix up space-indentation and tab-indentation. > > I do not know if it is a standard way either. > > This is the default

Re: [PATCH 2/2] streamline_config.pl: Add softtabstop=4 for vim users

2021-03-25 Thread Steven Rostedt
On Thu, 25 Mar 2021 23:09:38 +0900 Masahiro Yamada wrote: > > > Not all people use vim. > > > > I don't use it either. I was trying to make vim match emacs. Of course for > > those that use something else, it wont help. I'm curious, what's your main > > editor that you use? > > > I use

Re: [PATCH 2/2] streamline_config.pl: Add softtabstop=4 for vim users

2021-03-25 Thread Masahiro Yamada
On Thu, Mar 25, 2021 at 10:50 PM Steven Rostedt wrote: > > On Thu, 25 Mar 2021 15:20:13 +0900 > Masahiro Yamada wrote: > > > > > The root cause of inconsistency is that > > you mix up space-indentation and tab-indentation. > > I do not know if it is a standard way either. > > This is the default

Re: [PATCH 2/2] streamline_config.pl: Add softtabstop=4 for vim users

2021-03-25 Thread Steven Rostedt
On Thu, 25 Mar 2021 15:20:13 +0900 Masahiro Yamada wrote: > > The root cause of inconsistency is that > you mix up space-indentation and tab-indentation. > I do not know if it is a standard way either. This is the default way emacs has edited perl files for as long as I can remember (back to

Re: [PATCH 2/2] streamline_config.pl: Add softtabstop=4 for vim users

2021-03-25 Thread Masahiro Yamada
On Wed, Mar 24, 2021 at 10:54 PM Steven Rostedt wrote: > > On Wed, 24 Mar 2021 15:01:13 +0900 > Masahiro Yamada wrote: > > > On Tue, Mar 23, 2021 at 6:40 AM Steven Rostedt wrote: > > > > > > From: "Steven Rostedt (VMware)" > > > > > > The tab stop for Perl files is by default (at least in

Re: [PATCH 2/2] streamline_config.pl: Add softtabstop=4 for vim users

2021-03-24 Thread Steven Rostedt
On Wed, 24 Mar 2021 09:54:17 -0400 Steven Rostedt wrote: > This code doesn't change much, so I'm fine with that. But for ktest.pl, I'm > adding it. Anyway, I'm not going to ask you to take the second patch if you don't like it, but would you take the first patch? -- Steve

Re: [PATCH 2/2] streamline_config.pl: Add softtabstop=4 for vim users

2021-03-24 Thread Steven Rostedt
On Wed, 24 Mar 2021 15:01:13 +0900 Masahiro Yamada wrote: > On Tue, Mar 23, 2021 at 6:40 AM Steven Rostedt wrote: > > > > From: "Steven Rostedt (VMware)" > > > > The tab stop for Perl files is by default (at least in emacs) to be 4 > > spaces, where a tab is used for all 8 spaces. Add a local

Re: [PATCH 2/2] streamline_config.pl: Add softtabstop=4 for vim users

2021-03-24 Thread Masahiro Yamada
On Tue, Mar 23, 2021 at 6:40 AM Steven Rostedt wrote: > > From: "Steven Rostedt (VMware)" > > The tab stop for Perl files is by default (at least in emacs) to be 4 > spaces, where a tab is used for all 8 spaces. Add a local variable comment > to make vim do the same by default, and this will

[PATCH 2/2] streamline_config.pl: Add softtabstop=4 for vim users

2021-03-22 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" The tab stop for Perl files is by default (at least in emacs) to be 4 spaces, where a tab is used for all 8 spaces. Add a local variable comment to make vim do the same by default, and this will help keep the file consistent in the future when others edit it via