On 16/12/20 18:26, Reinette Chatre wrote:
> Hi Valentin,
>> So that's part paranoia and part nonsense from my end - the contents of
>> smp_call() shouldn't matter here.
>>
>> If we distill the code to:
>>
>>tsk->closid = x;
>>
>>if (task_curr(tsk))
>>smp_call(...);
>>
>> It is
Hi Valentin,
On 12/16/2020 9:41 AM, Valentin Schneider wrote:
On 14/12/20 18:41, Reinette Chatre wrote:
- return ret;
+
+ /*
+* By now, the task's closid and rmid are set. If the task is current
+* on a CPU, the PQR_ASSOC MSR needs to be updated to make the
On 14/12/20 18:41, Reinette Chatre wrote:
>>> - return ret;
>>> +
>>> + /*
>>> +* By now, the task's closid and rmid are set. If the task is current
>>> +* on a CPU, the PQR_ASSOC MSR needs to be updated to make the resource
>>> +* group go into effect. If the task is not
Hi Valentin,
On 12/11/2020 12:46 PM, Valentin Schneider wrote:
On 03/12/20 23:25, Reinette Chatre wrote:
Fixes: e02737d5b826 ("x86/intel_rdt: Add tasks files")
Reported-by: Shakeel Butt
Reported-by: Valentin Schneider
Signed-off-by: Fenghua Yu
Signed-off-by: Reinette Chatre
Reviewed-by:
On 03/12/20 23:25, Reinette Chatre wrote:
> Fixes: e02737d5b826 ("x86/intel_rdt: Add tasks files")
> Reported-by: Shakeel Butt
> Reported-by: Valentin Schneider
> Signed-off-by: Fenghua Yu
> Signed-off-by: Reinette Chatre
> Reviewed-by: Tony Luck
> Cc: sta...@vger.kernel.org
Some pedantic
Hi James,
On 12/9/2020 8:51 AM, James Morse wrote:
Hi Reinette, Fenghua,
Subject nit: I think 'use IPI instead of task_work() to update PQR_ASSOC_MSR'
conveys the
guts of this change more quickly!
Sure. Thank you. A small change is that I plan to write "PQR_ASSOC MSR"
instead to closer
Hi Reinette, Fenghua,
Subject nit: I think 'use IPI instead of task_work() to update PQR_ASSOC_MSR'
conveys the
guts of this change more quickly!
On 03/12/2020 23:25, Reinette Chatre wrote:
> From: Fenghua Yu
>
> Currently when moving a task to a resource group the PQR_ASSOC MSR
> is updated
From: Fenghua Yu
Currently when moving a task to a resource group the PQR_ASSOC MSR
is updated with the new closid and rmid in an added task callback.
If the task is running the work is run as soon as possible. If the
task is not running the work is executed later in the kernel exit path
when
8 matches
Mail list logo
