Re: [PATCH 3/6] mm/page_owner: copy last_migrate_reason in copy_page_owner()

2016-05-12 Thread Vlastimil Babka
On 05/12/2016 04:58 AM, Joonsoo Kim wrote: On Tue, May 10, 2016 at 05:13:12PM +0200, Vlastimil Babka wrote: Hmm... if it is the case, other fields are also misleading. I think that we can tolerate this corner case and keeping function semantic as function name suggests is better practice.

Re: [PATCH 3/6] mm/page_owner: copy last_migrate_reason in copy_page_owner()

2016-05-12 Thread Vlastimil Babka
On 05/12/2016 04:58 AM, Joonsoo Kim wrote: On Tue, May 10, 2016 at 05:13:12PM +0200, Vlastimil Babka wrote: Hmm... if it is the case, other fields are also misleading. I think that we can tolerate this corner case and keeping function semantic as function name suggests is better practice.

Re: [PATCH 3/6] mm/page_owner: copy last_migrate_reason in copy_page_owner()

2016-05-11 Thread Joonsoo Kim
On Tue, May 10, 2016 at 05:13:12PM +0200, Vlastimil Babka wrote: > On 05/03/2016 07:23 AM, js1...@gmail.com wrote: > >From: Joonsoo Kim > > > >Currently, copy_page_owner() doesn't copy all the owner information. > >It skips last_migrate_reason because copy_page_owner() is

Re: [PATCH 3/6] mm/page_owner: copy last_migrate_reason in copy_page_owner()

2016-05-11 Thread Joonsoo Kim
On Tue, May 10, 2016 at 05:13:12PM +0200, Vlastimil Babka wrote: > On 05/03/2016 07:23 AM, js1...@gmail.com wrote: > >From: Joonsoo Kim > > > >Currently, copy_page_owner() doesn't copy all the owner information. > >It skips last_migrate_reason because copy_page_owner() is used for > >migration

Re: [PATCH 3/6] mm/page_owner: copy last_migrate_reason in copy_page_owner()

2016-05-10 Thread Vlastimil Babka
On 05/03/2016 07:23 AM, js1...@gmail.com wrote: From: Joonsoo Kim Currently, copy_page_owner() doesn't copy all the owner information. It skips last_migrate_reason because copy_page_owner() is used for migration and it will be properly set soon. But, following patch

Re: [PATCH 3/6] mm/page_owner: copy last_migrate_reason in copy_page_owner()

2016-05-10 Thread Vlastimil Babka
On 05/03/2016 07:23 AM, js1...@gmail.com wrote: From: Joonsoo Kim Currently, copy_page_owner() doesn't copy all the owner information. It skips last_migrate_reason because copy_page_owner() is used for migration and it will be properly set soon. But, following patch will use copy_page_owner()

[PATCH 3/6] mm/page_owner: copy last_migrate_reason in copy_page_owner()

2016-05-02 Thread js1304
From: Joonsoo Kim Currently, copy_page_owner() doesn't copy all the owner information. It skips last_migrate_reason because copy_page_owner() is used for migration and it will be properly set soon. But, following patch will use copy_page_owner() and this skip will cause

[PATCH 3/6] mm/page_owner: copy last_migrate_reason in copy_page_owner()

2016-05-02 Thread js1304
From: Joonsoo Kim Currently, copy_page_owner() doesn't copy all the owner information. It skips last_migrate_reason because copy_page_owner() is used for migration and it will be properly set soon. But, following patch will use copy_page_owner() and this skip will cause the problem that