Re: [PATCH 3/9] bio-integrity: bio_integrity_advance must update integrity seed

Dmitry, > AFAIU: bip->bip_iter.bi_sector is always equals to bio->bi_iter.bi_sector > at least bip_set_seed() and bip_get_seed() relays on that. > Only bip->bip_vec must be advanced in intervals (this behavior not > changed by the patch this patch). Yep, I realized that a bit after sending but

Re: [PATCH 3/9] bio-integrity: bio_integrity_advance must update integrity seed

Dmitry, > AFAIU: bip->bip_iter.bi_sector is always equals to bio->bi_iter.bi_sector > at least bip_set_seed() and bip_get_seed() relays on that. > Only bip->bip_vec must be advanced in intervals (this behavior not > changed by the patch this patch). Yep, I realized that a bit after sending but

Re: [PATCH 3/9] bio-integrity: bio_integrity_advance must update integrity seed

"Martin K. Petersen" writes: > Dmitry Monakhov writes: > >> SCSI drivers do care about bip_seed so we must update it accordingly. > >> +bip->bip_iter.bi_sector += bytes_done >> 9; > > This needs to count protection intervals. Otherwise

Re: [PATCH 3/9] bio-integrity: bio_integrity_advance must update integrity seed

"Martin K. Petersen" writes: > Dmitry Monakhov writes: > >> SCSI drivers do care about bip_seed so we must update it accordingly. > >> +bip->bip_iter.bi_sector += bytes_done >> 9; > > This needs to count protection intervals. Otherwise things will break > for block sizes different from 512

Re: [PATCH 3/9] bio-integrity: bio_integrity_advance must update integrity seed

Dmitry Monakhov writes: > SCSI drivers do care about bip_seed so we must update it accordingly. > + bip->bip_iter.bi_sector += bytes_done >> 9; This needs to count protection intervals. Otherwise things will break for block sizes different from 512 bytes. -- Martin

Re: [PATCH 3/9] bio-integrity: bio_integrity_advance must update integrity seed

Dmitry Monakhov writes: > SCSI drivers do care about bip_seed so we must update it accordingly. > + bip->bip_iter.bi_sector += bytes_done >> 9; This needs to count protection intervals. Otherwise things will break for block sizes different from 512 bytes. -- Martin K. Petersen

Re: [PATCH 3/9] bio-integrity: bio_integrity_advance must update integrity seed

Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH 3/9] bio-integrity: bio_integrity_advance must update integrity seed

Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH 3/9] bio-integrity: bio_integrity_advance must update integrity seed

On 04/04/2017 08:56 PM, Dmitry Monakhov wrote: > SCSI drivers do care about bip_seed so we must update it accordingly. > > Signed-off-by: Dmitry Monakhov > --- > block/bio-integrity.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/block/bio-integrity.c

Re: [PATCH 3/9] bio-integrity: bio_integrity_advance must update integrity seed

On 04/04/2017 08:56 PM, Dmitry Monakhov wrote: > SCSI drivers do care about bip_seed so we must update it accordingly. > > Signed-off-by: Dmitry Monakhov > --- > block/bio-integrity.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/block/bio-integrity.c b/block/bio-integrity.c > index

[PATCH 3/9] bio-integrity: bio_integrity_advance must update integrity seed

SCSI drivers do care about bip_seed so we must update it accordingly. Signed-off-by: Dmitry Monakhov --- block/bio-integrity.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/bio-integrity.c b/block/bio-integrity.c index b5009a8..82a6ffb 100644 ---

[PATCH 3/9] bio-integrity: bio_integrity_advance must update integrity seed

SCSI drivers do care about bip_seed so we must update it accordingly. Signed-off-by: Dmitry Monakhov --- block/bio-integrity.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/bio-integrity.c b/block/bio-integrity.c index b5009a8..82a6ffb 100644 --- a/block/bio-integrity.c +++