Re: [PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim v2

Dmitry Monakhov writes: > bio_integrity_trim inherent it's interface from bio_trim and accept > offset and size, but this API is error prone because data offset must > always be insync with bio's data offset. That is why we have integrity > update hook in bio_advance() > >

Re: [PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim v2

Dmitry Monakhov writes: > bio_integrity_trim inherent it's interface from bio_trim and accept > offset and size, but this API is error prone because data offset must > always be insync with bio's data offset. That is why we have integrity > update hook in bio_advance() > > So only meaningful

Re: [PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim v2

Please drop the v2 from the subject line and move your changelog either into the cover letter (preferred) or at least below the --- line. Otherwise looks good: Reviewed-by: Christoph Hellwig

Re: [PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim v2

Please drop the v2 from the subject line and move your changelog either into the cover letter (preferred) or at least below the --- line. Otherwise looks good: Reviewed-by: Christoph Hellwig

Re: [PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim v2

On 04/04/2017 08:56 PM, Dmitry Monakhov wrote: > bio_integrity_trim inherent it's interface from bio_trim and accept > offset and size, but this API is error prone because data offset > must always be insync with bio's data offset. That is why we have > integrity update hook in bio_advance() > >

Re: [PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim v2

On 04/04/2017 08:56 PM, Dmitry Monakhov wrote: > bio_integrity_trim inherent it's interface from bio_trim and accept > offset and size, but this API is error prone because data offset > must always be insync with bio's data offset. That is why we have > integrity update hook in bio_advance() > >

[PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim v2

bio_integrity_trim inherent it's interface from bio_trim and accept offset and size, but this API is error prone because data offset must always be insync with bio's data offset. That is why we have integrity update hook in bio_advance() So only meaningful values are: offset == 0, sectors ==

[PATCH 4/9] bio-integrity: fix interface for bio_integrity_trim v2

bio_integrity_trim inherent it's interface from bio_trim and accept offset and size, but this API is error prone because data offset must always be insync with bio's data offset. That is why we have integrity update hook in bio_advance() So only meaningful values are: offset == 0, sectors ==