Re: [PATCH 5/7] ntb_hw_switchtec: Expand PFF CSR registers

2017-12-05 Thread Jon Mason
On Tue, Dec 5, 2017 at 2:40 PM, Logan Gunthorpe wrote: > > > On 05/12/17 12:12 PM, Jon Mason wrote: >> >> It sucks that we don't already have a struct for PCI config space we >> can reuse here. If you find the time, it would be good to add in the >> future to reduce

Re: [PATCH 5/7] ntb_hw_switchtec: Expand PFF CSR registers

2017-12-05 Thread Jon Mason
On Tue, Dec 5, 2017 at 2:40 PM, Logan Gunthorpe wrote: > > > On 05/12/17 12:12 PM, Jon Mason wrote: >> >> It sucks that we don't already have a struct for PCI config space we >> can reuse here. If you find the time, it would be good to add in the >> future to reduce duplicate code here and in

Re: [PATCH 5/7] ntb_hw_switchtec: Expand PFF CSR registers

2017-12-05 Thread Logan Gunthorpe
On 05/12/17 12:12 PM, Jon Mason wrote: It sucks that we don't already have a struct for PCI config space we can reuse here. If you find the time, it would be good to add in the future to reduce duplicate code here and in the PCI core. However, this patch is fine without it. I agree. And

Re: [PATCH 5/7] ntb_hw_switchtec: Expand PFF CSR registers

2017-12-05 Thread Logan Gunthorpe
On 05/12/17 12:12 PM, Jon Mason wrote: It sucks that we don't already have a struct for PCI config space we can reuse here. If you find the time, it would be good to add in the future to reduce duplicate code here and in the PCI core. However, this patch is fine without it. I agree. And

Re: [PATCH 5/7] ntb_hw_switchtec: Expand PFF CSR registers

2017-12-05 Thread Jon Mason
On Wed, Nov 29, 2017 at 12:55 PM, Logan Gunthorpe wrote: > The PFF CSR registers actual mirrors the PCI configuration space > for all the ports in the switch. Previously, this was not needed by > the driver but will be used by the crosslink code to enumerate the > bus in an

Re: [PATCH 5/7] ntb_hw_switchtec: Expand PFF CSR registers

2017-12-05 Thread Jon Mason
On Wed, Nov 29, 2017 at 12:55 PM, Logan Gunthorpe wrote: > The PFF CSR registers actual mirrors the PCI configuration space > for all the ports in the switch. Previously, this was not needed by > the driver but will be used by the crosslink code to enumerate the > bus in an host-less centre

[PATCH 5/7] ntb_hw_switchtec: Expand PFF CSR registers

2017-11-29 Thread Logan Gunthorpe
The PFF CSR registers actual mirrors the PCI configuration space for all the ports in the switch. Previously, this was not needed by the driver but will be used by the crosslink code to enumerate the bus in an host-less centre partition. Signed-off-by: Logan Gunthorpe ---

[PATCH 5/7] ntb_hw_switchtec: Expand PFF CSR registers

2017-11-29 Thread Logan Gunthorpe
The PFF CSR registers actual mirrors the PCI configuration space for all the ports in the switch. Previously, this was not needed by the driver but will be used by the crosslink code to enumerate the bus in an host-less centre partition. Signed-off-by: Logan Gunthorpe ---