Re: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open

On 1/21/21 5:44 PM, Jiri Kosina wrote: > On Thu, 21 Jan 2021, Jiri Kosina wrote: > >> I am currently waiting for confirmation by the original reporter that the >> patch below fixes the issue. > > ... a now a patch that actually compiles :) (made a mistake when > forward-porting from the

Re: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open

On Thu, 21 Jan 2021, Denis Efremov wrote: > > From: Jiri Kosina > > Subject: [PATCH v2] floppy: reintroduce O_NDELAY fix > > > > Originally fixed in 09954bad4 ("floppy: refactor open() flags handling") > > then reverted for unknown reason in f2791e7eadf437 instead of taking > > the

Re: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open

On 1/21/21 1:25 PM, Jiri Kosina wrote: > On Thu, 21 Jan 2021, Denis Efremov wrote: > >> I think it's hard to recall the exact reasons after so many years. > > Yeah, I guess so :) > >> I'll send a patch today based on this one. > > I am currently waiting for confirmation by the original

Re: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open

On Thu, 21 Jan 2021, Jiri Kosina wrote: > I am currently waiting for confirmation by the original reporter that the > patch below fixes the issue. ... a now a patch that actually compiles :) (made a mistake when forward-porting from the older kernel on which this has been reported). From:

Re: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open

On Thu, 21 Jan 2021, Denis Efremov wrote: > I think it's hard to recall the exact reasons after so many years. Yeah, I guess so :) > I'll send a patch today based on this one. I am currently waiting for confirmation by the original reporter that the patch below fixes the issue. From: Jiri

Re: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open

Hi, On 1/19/21 6:53 PM, Jiri Kosina wrote: > On Mon, 25 Jul 2016, Jens Axboe wrote: > >>> From: Jiri Kosina >>> >>> Commit 09954bad4 ("floppy: refactor open() flags handling"), as a >>> side-effect, causes open(/dev/fdX, O_ACCMODE) to fail. It turns out that >>> this is being used setfdprm

Re: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open

On Mon, 25 Jul 2016, Jens Axboe wrote: > > From: Jiri Kosina > > > > Commit 09954bad4 ("floppy: refactor open() flags handling"), as a > > side-effect, causes open(/dev/fdX, O_ACCMODE) to fail. It turns out that > > this is being used setfdprm userspace for ioctl-only open(). > > > > Reintroduce

Re: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open

On 06/30/2016 05:18 AM, Jiri Kosina wrote: From: Jiri Kosina Commit 09954bad4 ("floppy: refactor open() flags handling"), as a side-effect, causes open(/dev/fdX, O_ACCMODE) to fail. It turns out that this is being used setfdprm userspace for ioctl-only open(). Reintroduce

Re: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open

On 06/30/2016 05:18 AM, Jiri Kosina wrote: From: Jiri Kosina Commit 09954bad4 ("floppy: refactor open() flags handling"), as a side-effect, causes open(/dev/fdX, O_ACCMODE) to fail. It turns out that this is being used setfdprm userspace for ioctl-only open(). Reintroduce back the original

Re: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open

On Thu, Jun 30, 2016 at 01:18:00PM +0200, Jiri Kosina wrote: > From: Jiri Kosina > > Commit 09954bad4 ("floppy: refactor open() flags handling"), as a > side-effect, causes open(/dev/fdX, O_ACCMODE) to fail. It turns out that > this is being used setfdprm userspace for

Re: [PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open

On Thu, Jun 30, 2016 at 01:18:00PM +0200, Jiri Kosina wrote: > From: Jiri Kosina > > Commit 09954bad4 ("floppy: refactor open() flags handling"), as a > side-effect, causes open(/dev/fdX, O_ACCMODE) to fail. It turns out that > this is being used setfdprm userspace for ioctl-only open(). > >

[PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open

From: Jiri Kosina Commit 09954bad4 ("floppy: refactor open() flags handling"), as a side-effect, causes open(/dev/fdX, O_ACCMODE) to fail. It turns out that this is being used setfdprm userspace for ioctl-only open(). Reintroduce back the original behavior wrt

[PATCH RESEND] floppy: fix open(O_ACCMODE) for ioctl-only open

From: Jiri Kosina Commit 09954bad4 ("floppy: refactor open() flags handling"), as a side-effect, causes open(/dev/fdX, O_ACCMODE) to fail. It turns out that this is being used setfdprm userspace for ioctl-only open(). Reintroduce back the original behavior wrt !(FMODE_READ|FMODE_WRITE)