Re: [PATCH V2] mm/page_alloc: Ensure that HUGETLB_PAGE_ORDER is less than MAX_ORDER

2021-04-20 Thread David Hildenbrand
Hi Christoph, thanks for your insight. You can have larger blocks but you would need to allocate multiple contigous max order blocks or do it at boot time before the buddy allocator is active. What IA64 did was to do this at boot time thereby avoiding the buddy lists. And it had a separate

Re: [PATCH V2] mm/page_alloc: Ensure that HUGETLB_PAGE_ORDER is less than MAX_ORDER

2021-04-19 Thread Christoph Lameter
On Mon, 19 Apr 2021, Anshuman Khandual wrote: > >> Unfortunately the build test fails on both the platforms (powerpc and ia64) > >> which subscribe HUGETLB_PAGE_SIZE_VARIABLE and where this check would make > >> sense. I some how overlooked the cross compile build failure that actually > >>

Re: [PATCH V2] mm/page_alloc: Ensure that HUGETLB_PAGE_ORDER is less than MAX_ORDER

2021-04-18 Thread Anshuman Khandual
On 4/12/21 2:17 PM, David Hildenbrand wrote: > On 12.04.21 10:06, Anshuman Khandual wrote: >> + linuxppc-...@lists.ozlabs.org >> + linux-i...@vger.kernel.org >> >> On 4/12/21 9:18 AM, Anshuman Khandual wrote: >>> pageblock_order must always be less than MAX_ORDER, otherwise it might lead >>> to

Re: [PATCH V2] mm/page_alloc: Ensure that HUGETLB_PAGE_ORDER is less than MAX_ORDER

2021-04-12 Thread David Hildenbrand
On 12.04.21 10:06, Anshuman Khandual wrote: + linuxppc-...@lists.ozlabs.org + linux-i...@vger.kernel.org On 4/12/21 9:18 AM, Anshuman Khandual wrote: pageblock_order must always be less than MAX_ORDER, otherwise it might lead to an warning during boot. A similar problem got fixed on arm64

Re: [PATCH V2] mm/page_alloc: Ensure that HUGETLB_PAGE_ORDER is less than MAX_ORDER

2021-04-12 Thread kernel test robot
Hi Anshuman, Thank you for the patch! Yet something to improve: [auto build test ERROR on hnaz-linux-mm/master] url: https://github.com/0day-ci/linux/commits/Anshuman-Khandual/mm-page_alloc-Ensure-that-HUGETLB_PAGE_ORDER-is-less-than-MAX_ORDER/20210412-114918 base:

Re: [PATCH V2] mm/page_alloc: Ensure that HUGETLB_PAGE_ORDER is less than MAX_ORDER

2021-04-12 Thread Anshuman Khandual
+ linuxppc-...@lists.ozlabs.org + linux-i...@vger.kernel.org On 4/12/21 9:18 AM, Anshuman Khandual wrote: > pageblock_order must always be less than MAX_ORDER, otherwise it might lead > to an warning during boot. A similar problem got fixed on arm64 platform > with the commit 79cc2ed5a716

[PATCH V2] mm/page_alloc: Ensure that HUGETLB_PAGE_ORDER is less than MAX_ORDER

2021-04-11 Thread Anshuman Khandual
pageblock_order must always be less than MAX_ORDER, otherwise it might lead to an warning during boot. A similar problem got fixed on arm64 platform with the commit 79cc2ed5a716 ("arm64/mm: Drop THP conditionality from FORCE_MAX_ZONEORDER"). Assert the above condition before HUGETLB_PAGE_ORDER