Re: [PATCH V7 1/4] perf/core: Add PERF_SAMPLE_DATA_PAGE_SIZE

2020-09-17 Thread Liang, Kan
On 9/17/2020 6:02 PM, Dave Hansen wrote: The problem is that the warning from the perf tool usually includes some hints regarding the cause of the warning or possible solution to workaround/fix the warning. What message should we deliver to the users? "Warning: Too many error page size.

Re: [PATCH V7 1/4] perf/core: Add PERF_SAMPLE_DATA_PAGE_SIZE

2020-09-17 Thread Dave Hansen
On 9/17/20 2:58 PM, Liang, Kan wrote: > The user space perf tool looks like a better place for this kind of > warning. The perf tool knows the total number of the samples. It also > knows the number of the page size 0 samples. We can set a threshold, > e.g., 90%. If 90% of the samples have the

Re: [PATCH V7 1/4] perf/core: Add PERF_SAMPLE_DATA_PAGE_SIZE

2020-09-17 Thread Liang, Kan
On 9/17/2020 5:24 PM, Dave Hansen wrote: On 9/17/20 2:16 PM, Liang, Kan wrote: One last concern as I look at this: I wish it was a bit more future-proof.  There are lots of weird things folks are trying to do with the page tables, like Address Space Isolation.  For instance, if you get a

Re: [PATCH V7 1/4] perf/core: Add PERF_SAMPLE_DATA_PAGE_SIZE

2020-09-17 Thread Liang, Kan
On 9/17/2020 3:00 PM, Dave Hansen wrote: On 9/17/20 6:52 AM, kan.li...@linux.intel.com wrote: + mm = current->mm; + if (!mm) { + /* +* For kernel threads and the like, use init_mm so that +* we can find kernel memory. +

Re: [PATCH V7 1/4] perf/core: Add PERF_SAMPLE_DATA_PAGE_SIZE

2020-09-17 Thread Dave Hansen
On 9/17/20 6:52 AM, kan.li...@linux.intel.com wrote: > + mm = current->mm; > + if (!mm) { > + /* > + * For kernel threads and the like, use init_mm so that > + * we can find kernel memory. > + */ > + mm = _mm; > + } I

[PATCH V7 1/4] perf/core: Add PERF_SAMPLE_DATA_PAGE_SIZE

2020-09-17 Thread kan . liang
From: Kan Liang Current perf can report both virtual addresses and physical addresses, but not the MMU page size. Without the MMU page size information of the utilized page, users cannot decide whether to promote/demote large pages to optimize memory usage. Add a new sample type for the data