Re: [PATCH v1 1/1] ACPI: NFIT: Import GUID before use

2021-12-17 Thread Dan Williams
On Fri, Dec 17, 2021 at 10:10 AM Rafael J. Wysocki wrote: > > On Mon, Dec 13, 2021 at 9:46 PM Andy Shevchenko > wrote: > > > > Strictly speaking the comparison between guid_t and raw buffer > > is not correct. Import GUID to variable of guid_t type and then > > compare. > > > > Signed-off-by:

Re: [PATCH v1 1/1] ACPI: NFIT: Import GUID before use

2021-12-17 Thread Rafael J. Wysocki
On Mon, Dec 13, 2021 at 9:46 PM Andy Shevchenko wrote: > > Strictly speaking the comparison between guid_t and raw buffer > is not correct. Import GUID to variable of guid_t type and then > compare. > > Signed-off-by: Andy Shevchenko Dan, are you going to take care of this or should I? > --- >

[PATCH v1 1/1] ACPI: NFIT: Import GUID before use

2021-12-13 Thread Andy Shevchenko
Strictly speaking the comparison between guid_t and raw buffer is not correct. Import GUID to variable of guid_t type and then compare. Signed-off-by: Andy Shevchenko --- drivers/acpi/nfit/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/nfit/core.c

Re: [PATCH v1 1/1] ACPI: NFIT: Import GUID before use

2021-04-16 Thread Dan Williams
On Fri, Apr 16, 2021 at 10:34 AM Andy Shevchenko wrote: > > On Fri, Apr 16, 2021 at 09:15:34AM -0700, Dan Williams wrote: > > On Fri, Apr 16, 2021 at 1:58 AM Andy Shevchenko > > wrote: > > > On Fri, Apr 16, 2021 at 8:28 AM Dan Williams > > > wrote: > > > > On Thu, Apr 15, 2021 at 6:59 AM Andy

Re: [PATCH v1 1/1] ACPI: NFIT: Import GUID before use

2021-04-16 Thread Andy Shevchenko
On Fri, Apr 16, 2021 at 09:15:34AM -0700, Dan Williams wrote: > On Fri, Apr 16, 2021 at 1:58 AM Andy Shevchenko > wrote: > > On Fri, Apr 16, 2021 at 8:28 AM Dan Williams > > wrote: > > > On Thu, Apr 15, 2021 at 6:59 AM Andy Shevchenko > > > wrote: > > > > > > > > Strictly speaking the

Re: [PATCH v1 1/1] ACPI: NFIT: Import GUID before use

2021-04-16 Thread Dan Williams
On Fri, Apr 16, 2021 at 1:58 AM Andy Shevchenko wrote: > > On Fri, Apr 16, 2021 at 8:28 AM Dan Williams wrote: > > > > On Thu, Apr 15, 2021 at 6:59 AM Andy Shevchenko > > wrote: > > > > > > Strictly speaking the comparison between guid_t and raw buffer > > > is not correct. Import GUID to

Re: [PATCH v1 1/1] ACPI: NFIT: Import GUID before use

2021-04-16 Thread Andy Shevchenko
On Fri, Apr 16, 2021 at 8:28 AM Dan Williams wrote: > > On Thu, Apr 15, 2021 at 6:59 AM Andy Shevchenko > wrote: > > > > Strictly speaking the comparison between guid_t and raw buffer > > is not correct. Import GUID to variable of guid_t type and then > > compare. > > Hmm, what about something

Re: [PATCH v1 1/1] ACPI: NFIT: Import GUID before use

2021-04-15 Thread Dan Williams
On Thu, Apr 15, 2021 at 6:59 AM Andy Shevchenko wrote: > > Strictly speaking the comparison between guid_t and raw buffer > is not correct. Import GUID to variable of guid_t type and then > compare. Hmm, what about something like the following instead, because it adds safety. Any concerns about

[PATCH v1 1/1] ACPI: NFIT: Import GUID before use

2021-04-15 Thread Andy Shevchenko
Strictly speaking the comparison between guid_t and raw buffer is not correct. Import GUID to variable of guid_t type and then compare. Signed-off-by: Andy Shevchenko --- drivers/acpi/nfit/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/nfit/core.c