Re: [PATCH v1 1/3] mux: gpio: Use bitmap API instead of direct assignment

2021-03-30 Thread Peter Rosin
Hi! On 2021-03-26 18:23, Andy Shevchenko wrote: > Assigning bitmaps like it's done in the driver might be error prone. > Fix this by using bitmap API. A bit strongly worded perhaps, since the size of a mux chip with anywhere near 31 inputs and 2^31 possible selections is a bit ridiculous. Please

Re: [PATCH v1 1/3] mux: gpio: Use bitmap API instead of direct assignment

2021-03-29 Thread Andy Shevchenko
On Fri, Mar 26, 2021 at 07:23:59PM +0200, Andy Shevchenko wrote: > Assigning bitmaps like it's done in the driver might be error prone. > Fix this by using bitmap API. Peter, are you okay with the patches? Should I reroute them to Greg? -- With Best Regards, Andy Shevchenko

[PATCH v1 1/3] mux: gpio: Use bitmap API instead of direct assignment

2021-03-26 Thread Andy Shevchenko
Assigning bitmaps like it's done in the driver might be error prone. Fix this by using bitmap API. Signed-off-by: Andy Shevchenko --- drivers/mux/gpio.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/mux/gpio.c b/drivers/mux/gpio.c index