Re: [PATCH v12 05/10] arm64: Kprobes with single stepping support

On 05/17/2016 05:10 AM, Huang Shijie wrote: On Wed, Apr 27, 2016 at 02:53:00PM -0400, David Long wrote: From: Sandeepa Prabhu + +static bool __kprobes aarch64_insn_is_steppable(u32 insn) Could we add more comment for this function? In the comment, we can tell

Re: [PATCH v12 05/10] arm64: Kprobes with single stepping support

On 05/17/2016 05:10 AM, Huang Shijie wrote: On Wed, Apr 27, 2016 at 02:53:00PM -0400, David Long wrote: From: Sandeepa Prabhu + +static bool __kprobes aarch64_insn_is_steppable(u32 insn) Could we add more comment for this function? In the comment, we can tell that which type of instructions

Re: [PATCH v12 05/10] arm64: Kprobes with single stepping support

On 05/17/2016 11:29 PM, Masami Hiramatsu wrote: On Tue, 17 May 2016 16:58:09 +0800 Huang Shijie wrote: On Wed, Apr 27, 2016 at 02:53:00PM -0400, David Long wrote: + +/* + * Interrupts need to be disabled before single-step mode is set, and not + * reenabled until after

Re: [PATCH v12 05/10] arm64: Kprobes with single stepping support

On 05/17/2016 11:29 PM, Masami Hiramatsu wrote: On Tue, 17 May 2016 16:58:09 +0800 Huang Shijie wrote: On Wed, Apr 27, 2016 at 02:53:00PM -0400, David Long wrote: + +/* + * Interrupts need to be disabled before single-step mode is set, and not + * reenabled until after single-step mode ends.

Re: [PATCH v12 05/10] arm64: Kprobes with single stepping support

On 05/17/2016 04:58 AM, Huang Shijie wrote: On Wed, Apr 27, 2016 at 02:53:00PM -0400, David Long wrote: + +/* + * Interrupts need to be disabled before single-step mode is set, and not + * reenabled until after single-step mode ends. + * Without disabling interrupt on local CPU, there is a

Re: [PATCH v12 05/10] arm64: Kprobes with single stepping support

On 05/17/2016 04:58 AM, Huang Shijie wrote: On Wed, Apr 27, 2016 at 02:53:00PM -0400, David Long wrote: + +/* + * Interrupts need to be disabled before single-step mode is set, and not + * reenabled until after single-step mode ends. + * Without disabling interrupt on local CPU, there is a

Re: [PATCH v12 05/10] arm64: Kprobes with single stepping support

On 05/12/2016 11:01 AM, James Morse wrote: Hi David, Sandeepa, On 27/04/16 19:53, David Long wrote: From: Sandeepa Prabhu diff --git a/arch/arm64/kernel/kprobes.c b/arch/arm64/kernel/kprobes.c new file mode 100644 index 000..dfa1b1f --- /dev/null +++

Re: [PATCH v12 05/10] arm64: Kprobes with single stepping support

On 05/12/2016 11:01 AM, James Morse wrote: Hi David, Sandeepa, On 27/04/16 19:53, David Long wrote: From: Sandeepa Prabhu diff --git a/arch/arm64/kernel/kprobes.c b/arch/arm64/kernel/kprobes.c new file mode 100644 index 000..dfa1b1f --- /dev/null +++ b/arch/arm64/kernel/kprobes.c @@

Re: [PATCH v12 05/10] arm64: Kprobes with single stepping support

On Thu, 12 May 2016 16:01:54 +0100 James Morse wrote: > Hi David, Sandeepa, > > On 27/04/16 19:53, David Long wrote: > > From: Sandeepa Prabhu > > > diff --git a/arch/arm64/kernel/kprobes.c b/arch/arm64/kernel/kprobes.c > > new file mode

Re: [PATCH v12 05/10] arm64: Kprobes with single stepping support

On Thu, 12 May 2016 16:01:54 +0100 James Morse wrote: > Hi David, Sandeepa, > > On 27/04/16 19:53, David Long wrote: > > From: Sandeepa Prabhu > > > diff --git a/arch/arm64/kernel/kprobes.c b/arch/arm64/kernel/kprobes.c > > new file mode 100644 > > index 000..dfa1b1f > > --- /dev/null > >

Re: [PATCH v12 05/10] arm64: Kprobes with single stepping support

On Tue, 17 May 2016 16:58:09 +0800 Huang Shijie wrote: > On Wed, Apr 27, 2016 at 02:53:00PM -0400, David Long wrote: > > + > > +/* > > + * Interrupts need to be disabled before single-step mode is set, and not > > + * reenabled until after single-step mode ends. > > + *

Re: [PATCH v12 05/10] arm64: Kprobes with single stepping support

On Tue, 17 May 2016 16:58:09 +0800 Huang Shijie wrote: > On Wed, Apr 27, 2016 at 02:53:00PM -0400, David Long wrote: > > + > > +/* > > + * Interrupts need to be disabled before single-step mode is set, and not > > + * reenabled until after single-step mode ends. > > + * Without disabling

Re: [PATCH v12 05/10] arm64: Kprobes with single stepping support

On Wed, Apr 27, 2016 at 02:53:00PM -0400, David Long wrote: > From: Sandeepa Prabhu > + > +static bool __kprobes aarch64_insn_is_steppable(u32 insn) Could we add more comment for this function? In the comment, we can tell that which type of instructions are

Re: [PATCH v12 05/10] arm64: Kprobes with single stepping support

On Wed, Apr 27, 2016 at 02:53:00PM -0400, David Long wrote: > From: Sandeepa Prabhu > + > +static bool __kprobes aarch64_insn_is_steppable(u32 insn) Could we add more comment for this function? In the comment, we can tell that which type of instructions are steppable, which are not. > +{ > +

Re: [PATCH v12 05/10] arm64: Kprobes with single stepping support

On Wed, Apr 27, 2016 at 02:53:00PM -0400, David Long wrote: > + > +/* > + * Interrupts need to be disabled before single-step mode is set, and not > + * reenabled until after single-step mode ends. > + * Without disabling interrupt on local CPU, there is a chance of > + * interrupt occurrence in

Re: [PATCH v12 05/10] arm64: Kprobes with single stepping support

On Wed, Apr 27, 2016 at 02:53:00PM -0400, David Long wrote: > + > +/* > + * Interrupts need to be disabled before single-step mode is set, and not > + * reenabled until after single-step mode ends. > + * Without disabling interrupt on local CPU, there is a chance of > + * interrupt occurrence in

Re: [PATCH v12 05/10] arm64: Kprobes with single stepping support

Hi David, Sandeepa, On 27/04/16 19:53, David Long wrote: > From: Sandeepa Prabhu > diff --git a/arch/arm64/kernel/kprobes.c b/arch/arm64/kernel/kprobes.c > new file mode 100644 > index 000..dfa1b1f > --- /dev/null > +++ b/arch/arm64/kernel/kprobes.c > @@ -0,0

Re: [PATCH v12 05/10] arm64: Kprobes with single stepping support

Hi David, Sandeepa, On 27/04/16 19:53, David Long wrote: > From: Sandeepa Prabhu > diff --git a/arch/arm64/kernel/kprobes.c b/arch/arm64/kernel/kprobes.c > new file mode 100644 > index 000..dfa1b1f > --- /dev/null > +++ b/arch/arm64/kernel/kprobes.c > @@ -0,0 +1,520 @@ > +/* > + *

[PATCH v12 05/10] arm64: Kprobes with single stepping support

From: Sandeepa Prabhu Add support for basic kernel probes(kprobes) and jump probes (jprobes) for ARM64. Kprobes utilizes software breakpoint and single step debug exceptions supported on ARM v8. A software breakpoint is placed at the probe address to trap the

[PATCH v12 05/10] arm64: Kprobes with single stepping support

From: Sandeepa Prabhu Add support for basic kernel probes(kprobes) and jump probes (jprobes) for ARM64. Kprobes utilizes software breakpoint and single step debug exceptions supported on ARM v8. A software breakpoint is placed at the probe address to trap the kernel execution into the kprobe