Re: [EXT] Re: [PATCH v13 net-next 08/15] net: mvpp2: add FCA RXQ non occupied descriptor threshold

2021-02-11 Thread Russell King - ARM Linux admin
On Thu, Feb 11, 2021 at 01:22:35PM +, Stefan Chulski wrote: > > Ditto. > > > > I don't think these need to be fixed in the net tree, but it would still be > > nice > > to fix the problem. Please do so, as an initial patch in your series - so > > we can > > then backport if it turns out to

Re: [EXT] Re: [PATCH v13 net-next 08/15] net: mvpp2: add FCA RXQ non occupied descriptor threshold

2021-02-11 Thread Russell King - ARM Linux admin
On Thu, Feb 11, 2021 at 01:02:14PM +, Stefan Chulski wrote: > > On Thu, Feb 11, 2021 at 12:48:55PM +0200, stef...@marvell.com wrote: > > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > index 761f745..8b4073c 100644 >

RE: [EXT] Re: [PATCH v13 net-next 08/15] net: mvpp2: add FCA RXQ non occupied descriptor threshold

2021-02-11 Thread Stefan Chulski
> Ditto. > > I don't think these need to be fixed in the net tree, but it would still be > nice > to fix the problem. Please do so, as an initial patch in your series - so we > can > then backport if it turns out to eventually be necessary. > > Thanks. My series already has 15 patches and

RE: [EXT] Re: [PATCH v13 net-next 08/15] net: mvpp2: add FCA RXQ non occupied descriptor threshold

2021-02-11 Thread Stefan Chulski
@vger.kernel.org; > k...@kernel.org; m...@semihalf.com; and...@lunn.ch; > aten...@kernel.org; devicet...@vger.kernel.org; robh...@kernel.org; > sebastian.hesselba...@gmail.com; gregory.clem...@bootlin.com; linux- > arm-ker...@lists.infradead.org > Subject: [EXT] Re: [PATCH v13 net-next 08/15] ne

Re: [PATCH v13 net-next 08/15] net: mvpp2: add FCA RXQ non occupied descriptor threshold

2021-02-11 Thread Russell King - ARM Linux admin
On Thu, Feb 11, 2021 at 12:48:55PM +0200, stef...@marvell.com wrote: > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > index 761f745..8b4073c 100644 > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > +++

[PATCH v13 net-next 08/15] net: mvpp2: add FCA RXQ non occupied descriptor threshold

2021-02-11 Thread stefanc
From: Stefan Chulski The firmware needs to monitor the RX Non-occupied descriptor bits for flow control to move to XOFF mode. These bits need to be unmasked to be functional, but they will not raise interrupts as we leave the RX exception summary bit in MVPP2_ISR_RX_TX_MASK_REG clear.