Re: [PATCH v2] HID: core: check whether usage page item is after usage id item

2019-10-10 Thread Candle Sun
On Thu, Oct 10, 2019 at 8:24 PM Benjamin Tissoires wrote: > > On Wed, Oct 9, 2019 at 2:54 PM Candle Sun wrote: > > > > From: Candle Sun > > > > Upstream commit 58e75155009c ("HID: core: move Usage Page concatenation > > to Main item") adds support for Usage Page item after Usage ID items > >

Re: [PATCH v2] HID: core: check whether usage page item is after usage id item

2019-10-10 Thread Candle Sun
On Thu, Oct 10, 2019 at 8:17 PM Benjamin Tissoires wrote: > > On Thu, Oct 10, 2019 at 5:19 AM Candle Sun wrote: > > > > On Thu, Oct 10, 2019 at 2:00 AM Jiri Kosina wrote: > > > > > > On Wed, 9 Oct 2019, Nicolas Saenz Julienne wrote: > > > > > > > > diff --git a/drivers/hid/hid-core.c

Re: [PATCH v2] HID: core: check whether usage page item is after usage id item

2019-10-10 Thread Benjamin Tissoires
On Wed, Oct 9, 2019 at 2:54 PM Candle Sun wrote: > > From: Candle Sun > > Upstream commit 58e75155009c ("HID: core: move Usage Page concatenation > to Main item") adds support for Usage Page item after Usage ID items > (such as keyboards manufactured by Primax). > > Usage Page concatenation in

Re: [PATCH v2] HID: core: check whether usage page item is after usage id item

2019-10-10 Thread Benjamin Tissoires
On Thu, Oct 10, 2019 at 5:19 AM Candle Sun wrote: > > On Thu, Oct 10, 2019 at 2:00 AM Jiri Kosina wrote: > > > > On Wed, 9 Oct 2019, Nicolas Saenz Julienne wrote: > > > > > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > > > > index 3eaee2c..3394222 100644 > > > > ---

Re: [PATCH v2] HID: core: check whether usage page item is after usage id item

2019-10-10 Thread Nicolas Saenz Julienne
On Thu, 2019-10-10 at 11:05 +0800, Candle Sun wrote: > > > -static void hid_concatenate_usage_page(struct hid_parser *parser) > > > +static void hid_concatenate_last_usage_page(struct hid_parser *parser) > > > { > > > int i; > > > + unsigned int usage; > > > + unsigned int

Re: [PATCH v2] HID: core: check whether usage page item is after usage id item

2019-10-09 Thread Candle Sun
On Thu, Oct 10, 2019 at 2:00 AM Jiri Kosina wrote: > > On Wed, 9 Oct 2019, Nicolas Saenz Julienne wrote: > > > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > > > index 3eaee2c..3394222 100644 > > > --- a/drivers/hid/hid-core.c > > > +++ b/drivers/hid/hid-core.c > > > @@ -35,6

Re: [PATCH v2] HID: core: check whether usage page item is after usage id item

2019-10-09 Thread Candle Sun
On Thu, Oct 10, 2019 at 1:01 AM Nicolas Saenz Julienne wrote: > > On Wed, 2019-10-09 at 20:53 +0800, Candle Sun wrote: > > From: Candle Sun > > > > Upstream commit 58e75155009c ("HID: core: move Usage Page concatenation > > to Main item") adds support for Usage Page item after Usage ID items > >

Re: [PATCH v2] HID: core: check whether usage page item is after usage id item

2019-10-09 Thread Jiri Kosina
On Wed, 9 Oct 2019, Nicolas Saenz Julienne wrote: > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > > index 3eaee2c..3394222 100644 > > --- a/drivers/hid/hid-core.c > > +++ b/drivers/hid/hid-core.c > > @@ -35,6 +35,8 @@ > > > > #include "hid-ids.h" > > > > +#define

Re: [PATCH v2] HID: core: check whether usage page item is after usage id item

2019-10-09 Thread Nicolas Saenz Julienne
On Wed, 2019-10-09 at 20:53 +0800, Candle Sun wrote: > From: Candle Sun > > Upstream commit 58e75155009c ("HID: core: move Usage Page concatenation > to Main item") adds support for Usage Page item after Usage ID items > (such as keyboards manufactured by Primax). > > Usage Page concatenation

[PATCH v2] HID: core: check whether usage page item is after usage id item

2019-10-09 Thread Candle Sun
From: Candle Sun Upstream commit 58e75155009c ("HID: core: move Usage Page concatenation to Main item") adds support for Usage Page item after Usage ID items (such as keyboards manufactured by Primax). Usage Page concatenation in Main item works well for following report descriptor patterns: