Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2017-01-07 Thread Lars Ellenberg
On Sat, Jan 07, 2017 at 10:01:07AM +1100, NeilBrown wrote: > On Sat, Jan 07 2017, Mike Snitzer wrote: > > On Fri, Jan 06 2017 at 12:34pm -0500, > > Mikulas Patocka wrote: > >> On Fri, 6 Jan 2017, Mikulas Patocka wrote: > >> > On Wed, 4 Jan 2017, Mike Snitzer wrote: > >> > >

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2017-01-07 Thread Lars Ellenberg
On Sat, Jan 07, 2017 at 10:01:07AM +1100, NeilBrown wrote: > On Sat, Jan 07 2017, Mike Snitzer wrote: > > On Fri, Jan 06 2017 at 12:34pm -0500, > > Mikulas Patocka wrote: > >> On Fri, 6 Jan 2017, Mikulas Patocka wrote: > >> > On Wed, 4 Jan 2017, Mike Snitzer wrote: > >> > > On Wed, Jan 04 2017 at

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2017-01-06 Thread NeilBrown
On Sat, Jan 07 2017, Mike Snitzer wrote: > On Fri, Jan 06 2017 at 12:34pm -0500, > Mikulas Patocka wrote: > >> >> >> On Fri, 6 Jan 2017, Mikulas Patocka wrote: >> >> > >> > >> > On Wed, 4 Jan 2017, Mike Snitzer wrote: >> > >> > > On Wed, Jan 04 2017 at 12:12am -0500,

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2017-01-06 Thread NeilBrown
On Sat, Jan 07 2017, Mike Snitzer wrote: > On Fri, Jan 06 2017 at 12:34pm -0500, > Mikulas Patocka wrote: > >> >> >> On Fri, 6 Jan 2017, Mikulas Patocka wrote: >> >> > >> > >> > On Wed, 4 Jan 2017, Mike Snitzer wrote: >> > >> > > On Wed, Jan 04 2017 at 12:12am -0500, >> > > NeilBrown

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2017-01-06 Thread Mike Snitzer
On Fri, Jan 06 2017 at 12:34pm -0500, Mikulas Patocka wrote: > > > On Fri, 6 Jan 2017, Mikulas Patocka wrote: > > > > > > > On Wed, 4 Jan 2017, Mike Snitzer wrote: > > > > > On Wed, Jan 04 2017 at 12:12am -0500, > > > NeilBrown wrote: > > > > > > > >

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2017-01-06 Thread Mike Snitzer
On Fri, Jan 06 2017 at 12:34pm -0500, Mikulas Patocka wrote: > > > On Fri, 6 Jan 2017, Mikulas Patocka wrote: > > > > > > > On Wed, 4 Jan 2017, Mike Snitzer wrote: > > > > > On Wed, Jan 04 2017 at 12:12am -0500, > > > NeilBrown wrote: > > > > > > > > Suggested-by: NeilBrown > > > > >

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2017-01-06 Thread Mikulas Patocka
On Fri, 6 Jan 2017, Mikulas Patocka wrote: > > > On Wed, 4 Jan 2017, Mike Snitzer wrote: > > > On Wed, Jan 04 2017 at 12:12am -0500, > > NeilBrown wrote: > > > > > > Suggested-by: NeilBrown > > > > Signed-off-by: Jack Wang > >

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2017-01-06 Thread Mikulas Patocka
On Fri, 6 Jan 2017, Mikulas Patocka wrote: > > > On Wed, 4 Jan 2017, Mike Snitzer wrote: > > > On Wed, Jan 04 2017 at 12:12am -0500, > > NeilBrown wrote: > > > > > > Suggested-by: NeilBrown > > > > Signed-off-by: Jack Wang > > > > --- > > > > block/blk-core.c | 20 >

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2017-01-06 Thread Mikulas Patocka
On Wed, 4 Jan 2017, Mike Snitzer wrote: > On Wed, Jan 04 2017 at 12:12am -0500, > NeilBrown wrote: > > > On Tue, Jan 03 2017, Jack Wang wrote: > > > > > 2016-12-23 12:45 GMT+01:00 Lars Ellenberg : > > >> On Fri, Dec 23, 2016 at 09:49:53AM +0100,

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2017-01-06 Thread Mikulas Patocka
On Wed, 4 Jan 2017, Mike Snitzer wrote: > On Wed, Jan 04 2017 at 12:12am -0500, > NeilBrown wrote: > > > On Tue, Jan 03 2017, Jack Wang wrote: > > > > > 2016-12-23 12:45 GMT+01:00 Lars Ellenberg : > > >> On Fri, Dec 23, 2016 at 09:49:53AM +0100, Michael Wang wrote: > > >>> Dear Maintainers >

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2017-01-05 Thread 王金浦
2017-01-04 19:50 GMT+01:00 Mike Snitzer : > On Wed, Jan 04 2017 at 12:12am -0500, > NeilBrown wrote: > >> On Tue, Jan 03 2017, Jack Wang wrote: >> >> > 2016-12-23 12:45 GMT+01:00 Lars Ellenberg : >> >> On Fri, Dec 23, 2016 at

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2017-01-05 Thread 王金浦
2017-01-04 19:50 GMT+01:00 Mike Snitzer : > On Wed, Jan 04 2017 at 12:12am -0500, > NeilBrown wrote: > >> On Tue, Jan 03 2017, Jack Wang wrote: >> >> > 2016-12-23 12:45 GMT+01:00 Lars Ellenberg : >> >> On Fri, Dec 23, 2016 at 09:49:53AM +0100, Michael Wang wrote: >> >>> Dear Maintainers >> >>> >>

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2017-01-04 Thread Mike Snitzer
On Wed, Jan 04 2017 at 12:12am -0500, NeilBrown wrote: > On Tue, Jan 03 2017, Jack Wang wrote: > > > 2016-12-23 12:45 GMT+01:00 Lars Ellenberg : > >> On Fri, Dec 23, 2016 at 09:49:53AM +0100, Michael Wang wrote: > >>> Dear Maintainers > >>> > >>> I'd

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2017-01-04 Thread Mike Snitzer
On Wed, Jan 04 2017 at 12:12am -0500, NeilBrown wrote: > On Tue, Jan 03 2017, Jack Wang wrote: > > > 2016-12-23 12:45 GMT+01:00 Lars Ellenberg : > >> On Fri, Dec 23, 2016 at 09:49:53AM +0100, Michael Wang wrote: > >>> Dear Maintainers > >>> > >>> I'd like to ask for the status of this patch

Re: [dm-devel] [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2017-01-03 Thread NeilBrown
On Tue, Jan 03 2017, Jack Wang wrote: > 2016-12-23 12:45 GMT+01:00 Lars Ellenberg : >> On Fri, Dec 23, 2016 at 09:49:53AM +0100, Michael Wang wrote: >>> Dear Maintainers >>> >>> I'd like to ask for the status of this patch since we hit the >>> issue too during our

Re: [dm-devel] [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2017-01-03 Thread NeilBrown
On Tue, Jan 03 2017, Jack Wang wrote: > 2016-12-23 12:45 GMT+01:00 Lars Ellenberg : >> On Fri, Dec 23, 2016 at 09:49:53AM +0100, Michael Wang wrote: >>> Dear Maintainers >>> >>> I'd like to ask for the status of this patch since we hit the >>> issue too during our testing on md raid1. >>> >>>

Re: [dm-devel] [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2017-01-02 Thread Jack Wang
2016-12-23 12:45 GMT+01:00 Lars Ellenberg : > On Fri, Dec 23, 2016 at 09:49:53AM +0100, Michael Wang wrote: >> Dear Maintainers >> >> I'd like to ask for the status of this patch since we hit the >> issue too during our testing on md raid1. >> >> Split remainder bio_A

Re: [dm-devel] [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2017-01-02 Thread Jack Wang
2016-12-23 12:45 GMT+01:00 Lars Ellenberg : > On Fri, Dec 23, 2016 at 09:49:53AM +0100, Michael Wang wrote: >> Dear Maintainers >> >> I'd like to ask for the status of this patch since we hit the >> issue too during our testing on md raid1. >> >> Split remainder bio_A was queued ahead, following

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-12-23 Thread Lars Ellenberg
On Fri, Dec 23, 2016 at 09:49:53AM +0100, Michael Wang wrote: > Dear Maintainers > > I'd like to ask for the status of this patch since we hit the > issue too during our testing on md raid1. > > Split remainder bio_A was queued ahead, following by bio_B for > lower device, at this moment raid

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-12-23 Thread Lars Ellenberg
On Fri, Dec 23, 2016 at 09:49:53AM +0100, Michael Wang wrote: > Dear Maintainers > > I'd like to ask for the status of this patch since we hit the > issue too during our testing on md raid1. > > Split remainder bio_A was queued ahead, following by bio_B for > lower device, at this moment raid

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-12-23 Thread Michael Wang
Dear Maintainers I'd like to ask for the status of this patch since we hit the issue too during our testing on md raid1. Split remainder bio_A was queued ahead, following by bio_B for lower device, at this moment raid start freezing, the loop take out bio_A firstly and deliver it, which will

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-12-23 Thread Michael Wang
Dear Maintainers I'd like to ask for the status of this patch since we hit the issue too during our testing on md raid1. Split remainder bio_A was queued ahead, following by bio_B for lower device, at this moment raid start freezing, the loop take out bio_A firstly and deliver it, which will

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-08-10 Thread Eric Wheeler
On Tue, 19 Jul 2016, Lars Ellenberg wrote: > On Tue, Jul 12, 2016 at 10:32:33PM -0400, Mike Snitzer wrote: > > On Tue, Jul 12 2016 at 10:18pm -0400, > > Eric Wheeler wrote: > > > > > On Tue, 12 Jul 2016, NeilBrown wrote: > > > > > > > On Tue, Jul 12 2016, Lars

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-08-10 Thread Eric Wheeler
On Tue, 19 Jul 2016, Lars Ellenberg wrote: > On Tue, Jul 12, 2016 at 10:32:33PM -0400, Mike Snitzer wrote: > > On Tue, Jul 12 2016 at 10:18pm -0400, > > Eric Wheeler wrote: > > > > > On Tue, 12 Jul 2016, NeilBrown wrote: > > > > > > > On Tue, Jul 12 2016, Lars Ellenberg wrote: > > > > > >

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-07-25 Thread Jeff Moyer
Eric Wheeler writes: > [+cc Mikulas Patocka, Jeff Moyer; Do either of you have any input on Lars' > commentary related to patchwork #'s 9204125 and 7398411 and BZ#119841? ] Sorry, I don't have any time to look at this right now. Cheers, Jeff > > On Tue, 19 Jul

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-07-25 Thread Jeff Moyer
Eric Wheeler writes: > [+cc Mikulas Patocka, Jeff Moyer; Do either of you have any input on Lars' > commentary related to patchwork #'s 9204125 and 7398411 and BZ#119841? ] Sorry, I don't have any time to look at this right now. Cheers, Jeff > > On Tue, 19 Jul 2016, Lars Ellenberg wrote: >

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-07-21 Thread Eric Wheeler
[+cc Mikulas Patocka, Jeff Moyer; Do either of you have any input on Lars' commentary related to patchwork #'s 9204125 and 7398411 and BZ#119841? ] On Tue, 19 Jul 2016, Lars Ellenberg wrote: > On Tue, Jul 12, 2016 at 10:32:33PM -0400, Mike Snitzer wrote: > > On Tue, Jul 12 2016 at 10:18pm

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-07-21 Thread Eric Wheeler
[+cc Mikulas Patocka, Jeff Moyer; Do either of you have any input on Lars' commentary related to patchwork #'s 9204125 and 7398411 and BZ#119841? ] On Tue, 19 Jul 2016, Lars Ellenberg wrote: > On Tue, Jul 12, 2016 at 10:32:33PM -0400, Mike Snitzer wrote: > > On Tue, Jul 12 2016 at 10:18pm

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-07-19 Thread Lars Ellenberg
On Tue, Jul 12, 2016 at 10:32:33PM -0400, Mike Snitzer wrote: > On Tue, Jul 12 2016 at 10:18pm -0400, > Eric Wheeler wrote: > > > On Tue, 12 Jul 2016, NeilBrown wrote: > > > > > On Tue, Jul 12 2016, Lars Ellenberg wrote: > > > > > > > > > > > Instead, I suggest

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-07-19 Thread Lars Ellenberg
On Tue, Jul 12, 2016 at 10:32:33PM -0400, Mike Snitzer wrote: > On Tue, Jul 12 2016 at 10:18pm -0400, > Eric Wheeler wrote: > > > On Tue, 12 Jul 2016, NeilBrown wrote: > > > > > On Tue, Jul 12 2016, Lars Ellenberg wrote: > > > > > > > > > > > Instead, I suggest to distinguish between

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-07-12 Thread Mike Snitzer
On Tue, Jul 12 2016 at 10:18pm -0400, Eric Wheeler wrote: > On Tue, 12 Jul 2016, NeilBrown wrote: > > > On Tue, Jul 12 2016, Lars Ellenberg wrote: > > > > > > > > Instead, I suggest to distinguish between recursive calls to > > > generic_make_request(), and

Re: [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-07-12 Thread Mike Snitzer
On Tue, Jul 12 2016 at 10:18pm -0400, Eric Wheeler wrote: > On Tue, 12 Jul 2016, NeilBrown wrote: > > > On Tue, Jul 12 2016, Lars Ellenberg wrote: > > > > > > > > Instead, I suggest to distinguish between recursive calls to > > > generic_make_request(), and pushing back the remainder part

Re: [dm-devel] [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-07-12 Thread Eric Wheeler
On Tue, 12 Jul 2016, NeilBrown wrote: > On Tue, Jul 12 2016, Lars Ellenberg wrote: > > > > > Instead, I suggest to distinguish between recursive calls to > > generic_make_request(), and pushing back the remainder part in > > blk_queue_split(), by pointing current->bio_lists to a > >

Re: [dm-devel] [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-07-12 Thread Eric Wheeler
On Tue, 12 Jul 2016, NeilBrown wrote: > On Tue, Jul 12 2016, Lars Ellenberg wrote: > > > > > Instead, I suggest to distinguish between recursive calls to > > generic_make_request(), and pushing back the remainder part in > > blk_queue_split(), by pointing current->bio_lists to a > >

Re: [dm-devel] [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-07-11 Thread NeilBrown
On Tue, Jul 12 2016, Lars Ellenberg wrote: > > Instead, I suggest to distinguish between recursive calls to > generic_make_request(), and pushing back the remainder part in > blk_queue_split(), by pointing current->bio_lists to a > struct recursion_to_iteration_bio_lists { >

Re: [dm-devel] [PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-07-11 Thread NeilBrown
On Tue, Jul 12 2016, Lars Ellenberg wrote: > > Instead, I suggest to distinguish between recursive calls to > generic_make_request(), and pushing back the remainder part in > blk_queue_split(), by pointing current->bio_lists to a > struct recursion_to_iteration_bio_lists { >

[PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-07-11 Thread Lars Ellenberg
For a long time, generic_make_request() converts recursion into iteration by queuing recursive arguments on current->bio_list. This is convenient for stacking drivers, the top-most driver would take the originally submitted bio, and re-submit a re-mapped version of it, or one or more clones, or

[PATCH v2 1/1] block: fix blk_queue_split() resource exhaustion

2016-07-11 Thread Lars Ellenberg
For a long time, generic_make_request() converts recursion into iteration by queuing recursive arguments on current->bio_list. This is convenient for stacking drivers, the top-most driver would take the originally submitted bio, and re-submit a re-mapped version of it, or one or more clones, or