Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Thu, Mar 16, 2017 at 12:33 PM, Herbert Xu wrote: > On Wed, Mar 08, 2017 at 12:38:40PM -0500, Dan Streetman wrote: >> >> >> setting the ASYNC bit makes it synchronous? that seems backwards...? > > You set the ASYNC bit in the mask and leave it clear in the type. >

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Thu, Mar 16, 2017 at 12:33 PM, Herbert Xu wrote: > On Wed, Mar 08, 2017 at 12:38:40PM -0500, Dan Streetman wrote: >> >> >> setting the ASYNC bit makes it synchronous? that seems backwards...? > > You set the ASYNC bit in the mask and leave it clear in the type. > That way only algorithms with

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Wed, Mar 08, 2017 at 12:38:40PM -0500, Dan Streetman wrote: > > zswap gets the fun of being the first crypto compression consumer to > switch to the new api? ;-) BTW I think we should hold off on converting zswap for now. The reason is that I'd like to try out the new interface on IPcomp and

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Wed, Mar 08, 2017 at 12:38:40PM -0500, Dan Streetman wrote: > > zswap gets the fun of being the first crypto compression consumer to > switch to the new api? ;-) BTW I think we should hold off on converting zswap for now. The reason is that I'd like to try out the new interface on IPcomp and

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Thu, Mar 16, 2017 at 11:54:43AM -0400, Dan Streetman wrote: > > setting the ASYNC bit makes it synchronous? that seems backwards...? You set the ASYNC bit in the mask and leave it clear in the type. That way only algorithms with the ASYNC bit off will match. > Is the acomp interface fully

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Thu, Mar 16, 2017 at 11:54:43AM -0400, Dan Streetman wrote: > > setting the ASYNC bit makes it synchronous? that seems backwards...? You set the ASYNC bit in the mask and leave it clear in the type. That way only algorithms with the ASYNC bit off will match. > Is the acomp interface fully

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Thu, Mar 9, 2017 at 4:39 AM, Herbert Xu wrote: > On Wed, Mar 08, 2017 at 12:38:40PM -0500, Dan Streetman wrote: >> >> It looks like the crypto_scomp interface is buried under >> include/crypto/internal/scompress.h, however that's exactly what zswap >> should be

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Thu, Mar 9, 2017 at 4:39 AM, Herbert Xu wrote: > On Wed, Mar 08, 2017 at 12:38:40PM -0500, Dan Streetman wrote: >> >> It looks like the crypto_scomp interface is buried under >> include/crypto/internal/scompress.h, however that's exactly what zswap >> should be using. We don't need to switch

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Wed, Mar 08, 2017 at 12:38:40PM -0500, Dan Streetman wrote: > > It looks like the crypto_scomp interface is buried under > include/crypto/internal/scompress.h, however that's exactly what zswap > should be using. We don't need to switch to an asynchronous interface > that's rather

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Wed, Mar 08, 2017 at 12:38:40PM -0500, Dan Streetman wrote: > > It looks like the crypto_scomp interface is buried under > include/crypto/internal/scompress.h, however that's exactly what zswap > should be using. We don't need to switch to an asynchronous interface > that's rather

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Mon, Feb 27, 2017 at 9:40 AM, Mahipal Reddy wrote: > Hi Dan, > Thanks for your reply. > > On Sat, Feb 25, 2017 at 3:51 AM, Dan Streetman wrote: >> On Fri, Feb 24, 2017 at 11:05 AM, Mahipal Challa >> wrote: >>> This

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Mon, Feb 27, 2017 at 9:40 AM, Mahipal Reddy wrote: > Hi Dan, > Thanks for your reply. > > On Sat, Feb 25, 2017 at 3:51 AM, Dan Streetman wrote: >> On Fri, Feb 24, 2017 at 11:05 AM, Mahipal Challa >> wrote: >>> This adds support for kernel's new crypto acomp/scomp framework >>> to zswap. >>

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

Hi Dan, Thanks for your reply. On Sat, Feb 25, 2017 at 3:51 AM, Dan Streetman wrote: > On Fri, Feb 24, 2017 at 11:05 AM, Mahipal Challa > wrote: >> This adds support for kernel's new crypto acomp/scomp framework >> to zswap. > > I don't understand

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

Hi Dan, Thanks for your reply. On Sat, Feb 25, 2017 at 3:51 AM, Dan Streetman wrote: > On Fri, Feb 24, 2017 at 11:05 AM, Mahipal Challa > wrote: >> This adds support for kernel's new crypto acomp/scomp framework >> to zswap. > > I don't understand the point of this, zswap can't compress pages >

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Fri, Feb 24, 2017 at 11:05 AM, Mahipal Challa wrote: > This adds support for kernel's new crypto acomp/scomp framework > to zswap. I don't understand the point of this, zswap can't compress pages asynchronously, so what benefit do we get from using the async crypto

Re: [PATCH v2 1/1] mm: zswap - Add crypto acomp/scomp framework support

On Fri, Feb 24, 2017 at 11:05 AM, Mahipal Challa wrote: > This adds support for kernel's new crypto acomp/scomp framework > to zswap. I don't understand the point of this, zswap can't compress pages asynchronously, so what benefit do we get from using the async crypto api and then immediately