Re: [PATCH v2 1/2] net: sched: make default fifo qdiscs appear in the dump

2017-03-08 Thread Jiri Kosina
On Wed, 8 Mar 2017, Eric Dumazet wrote: > > +++ b/net/sched/sch_qfq.c > > @@ -494,6 +494,8 @@ static int qfq_change_class(struct Qdisc *sch, u32 > > classid, u32 parentid, > > goto destroy_class; > > } > > > > + if (cl->qdisc != _qdisc) > > +

Re: [PATCH v2 1/2] net: sched: make default fifo qdiscs appear in the dump

2017-03-08 Thread Jiri Kosina
On Wed, 8 Mar 2017, Eric Dumazet wrote: > > +++ b/net/sched/sch_qfq.c > > @@ -494,6 +494,8 @@ static int qfq_change_class(struct Qdisc *sch, u32 > > classid, u32 parentid, > > goto destroy_class; > > } > > > > + if (cl->qdisc != _qdisc) > > +

Re: [PATCH v2 1/2] net: sched: make default fifo qdiscs appear in the dump

2017-03-08 Thread Eric Dumazet
On Wed, 2017-03-08 at 13:03 +0100, Jiri Kosina wrote: > +++ b/net/sched/sch_qfq.c > @@ -494,6 +494,8 @@ static int qfq_change_class(struct Qdisc *sch, u32 > classid, u32 parentid, > goto destroy_class; > } > > + if (cl->qdisc != _qdisc) > +

Re: [PATCH v2 1/2] net: sched: make default fifo qdiscs appear in the dump

2017-03-08 Thread Eric Dumazet
On Wed, 2017-03-08 at 13:03 +0100, Jiri Kosina wrote: > +++ b/net/sched/sch_qfq.c > @@ -494,6 +494,8 @@ static int qfq_change_class(struct Qdisc *sch, u32 > classid, u32 parentid, > goto destroy_class; > } > > + if (cl->qdisc != _qdisc) > +

Re: [PATCH v2 1/2] net: sched: make default fifo qdiscs appear in the dump

2017-03-08 Thread Jiri Pirko
Wed, Mar 08, 2017 at 01:03:42PM CET, ji...@kernel.org wrote: >From: Jiri Kosina > >The original reason [1] for having hidden qdiscs (potential scalability >issues in qdisc_match_from_root() with single linked list in case of large >amount of qdiscs) has been invalidated by

Re: [PATCH v2 1/2] net: sched: make default fifo qdiscs appear in the dump

2017-03-08 Thread Jiri Pirko
Wed, Mar 08, 2017 at 01:03:42PM CET, ji...@kernel.org wrote: >From: Jiri Kosina > >The original reason [1] for having hidden qdiscs (potential scalability >issues in qdisc_match_from_root() with single linked list in case of large >amount of qdiscs) has been invalidated by 59cc1f61f0 ("net:

[PATCH v2 1/2] net: sched: make default fifo qdiscs appear in the dump

2017-03-08 Thread Jiri Kosina
From: Jiri Kosina The original reason [1] for having hidden qdiscs (potential scalability issues in qdisc_match_from_root() with single linked list in case of large amount of qdiscs) has been invalidated by 59cc1f61f0 ("net: sched: convert qdisc linked list to hashtable"). This

[PATCH v2 1/2] net: sched: make default fifo qdiscs appear in the dump

2017-03-08 Thread Jiri Kosina
From: Jiri Kosina The original reason [1] for having hidden qdiscs (potential scalability issues in qdisc_match_from_root() with single linked list in case of large amount of qdiscs) has been invalidated by 59cc1f61f0 ("net: sched: convert qdisc linked list to hashtable"). This allows us for