RE: [PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide

2021-04-15 Thread Don.Brace
-Original Message- From: Martin K. Petersen Subject: Re: [PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide > Some of the structs contain `atomic_t` values and are not intended to > be sent to IO controller as is. > > The change adds __packed to

Re: [PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide

2021-04-01 Thread Martin K. Petersen
On Tue, 30 Mar 2021 08:19:56 +0100, Sergei Trofimovich wrote: > Some of the structs contain `atomic_t` values and are not intended to be > sent to IO controller as is. > > The change adds __packed to every struct and union in the file. > Follow-up commits will fix `atomic_t` problems. > > The

Re: [PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide

2021-03-30 Thread Arnd Bergmann
On Tue, Mar 30, 2021 at 9:30 AM Arnd Bergmann wrote: > On Tue, Mar 30, 2021 at 9:22 AM Sergei Trofimovich wrote: > > > @@ -451,7 +452,7 @@ struct CommandList { > > bool retry_pending; > > struct hpsa_scsi_dev_t *device; > > atomic_t refcount; /* Must be last to avoid

Re: [PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide

2021-03-30 Thread Arnd Bergmann
On Tue, Mar 30, 2021 at 9:22 AM Sergei Trofimovich wrote: > > Some of the structs contain `atomic_t` values and are not intended to be > sent to IO controller as is. > > The change adds __packed to every struct and union in the file. > Follow-up commits will fix `atomic_t` problems. > > The

[PATCH v2 1/3] hpsa: use __packed on individual structs, not header-wide

2021-03-30 Thread Sergei Trofimovich
Some of the structs contain `atomic_t` values and are not intended to be sent to IO controller as is. The change adds __packed to every struct and union in the file. Follow-up commits will fix `atomic_t` problems. The commit is a no-op at least on ia64: $ diff -u <(objdump -d -r old.o)