Re: [PATCH v2 2/3] HID: logitech-hidpp: rework device validation

2019-10-17 Thread Benjamin Tissoires
On Wed, Oct 16, 2019 at 9:38 PM Andrey Smirnov wrote: > > On Wed, Oct 16, 2019 at 12:24 PM Benjamin Tissoires > wrote: > > > > Hi Andrey, > > > > On Wed, Oct 16, 2019 at 8:30 PM Andrey Smirnov > > wrote: > > > > > > G920 device only advertises REPORT_ID_HIDPP_LONG and > > >

Re: [PATCH v2 2/3] HID: logitech-hidpp: rework device validation

2019-10-16 Thread Andrey Smirnov
On Wed, Oct 16, 2019 at 12:24 PM Benjamin Tissoires wrote: > > Hi Andrey, > > On Wed, Oct 16, 2019 at 8:30 PM Andrey Smirnov > wrote: > > > > G920 device only advertises REPORT_ID_HIDPP_LONG and > > REPORT_ID_HIDPP_VERY_LONG in its HID report descriptor, so querying > > for

Re: [PATCH v2 2/3] HID: logitech-hidpp: rework device validation

2019-10-16 Thread Benjamin Tissoires
Hi Andrey, On Wed, Oct 16, 2019 at 8:30 PM Andrey Smirnov wrote: > > G920 device only advertises REPORT_ID_HIDPP_LONG and > REPORT_ID_HIDPP_VERY_LONG in its HID report descriptor, so querying > for REPORT_ID_HIDPP_SHORT with optional=false will always fail and > prevent G920 to be recognized as

[PATCH v2 2/3] HID: logitech-hidpp: rework device validation

2019-10-16 Thread Andrey Smirnov
G920 device only advertises REPORT_ID_HIDPP_LONG and REPORT_ID_HIDPP_VERY_LONG in its HID report descriptor, so querying for REPORT_ID_HIDPP_SHORT with optional=false will always fail and prevent G920 to be recognized as a valid HID++ device. To fix this and improve some other aspects, modify