Re: [PATCH v2 2/4] ntb_hw_intel: Style fixes: open code macros that just obfuscate code

2017-03-08 Thread Jon Mason
On Tue, Jan 10, 2017 at 05:33:37PM -0700, Logan Gunthorpe wrote: > As per a comments in [1] by Greg Kroah-Hartman, the ndev_* macros should > be cleaned up. This makes it more clear what's actually going on when > reading the code. > > [1] http://www.spinics.net/lists/linux-pci/msg56904.html > >

Re: [PATCH v2 2/4] ntb_hw_intel: Style fixes: open code macros that just obfuscate code

2017-03-08 Thread Jon Mason
On Tue, Jan 10, 2017 at 05:33:37PM -0700, Logan Gunthorpe wrote: > As per a comments in [1] by Greg Kroah-Hartman, the ndev_* macros should > be cleaned up. This makes it more clear what's actually going on when > reading the code. > > [1] http://www.spinics.net/lists/linux-pci/msg56904.html > >

[PATCH v2 2/4] ntb_hw_intel: Style fixes: open code macros that just obfuscate code

2017-01-10 Thread Logan Gunthorpe
As per a comments in [1] by Greg Kroah-Hartman, the ndev_* macros should be cleaned up. This makes it more clear what's actually going on when reading the code. [1] http://www.spinics.net/lists/linux-pci/msg56904.html Signed-off-by: Logan Gunthorpe ---

[PATCH v2 2/4] ntb_hw_intel: Style fixes: open code macros that just obfuscate code

2017-01-10 Thread Logan Gunthorpe
As per a comments in [1] by Greg Kroah-Hartman, the ndev_* macros should be cleaned up. This makes it more clear what's actually going on when reading the code. [1] http://www.spinics.net/lists/linux-pci/msg56904.html Signed-off-by: Logan Gunthorpe --- drivers/ntb/hw/intel/ntb_hw_intel.c | 192