Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-05 Thread Vivek Gautam
Hi Philipp, On 04/04/2017 06:17 PM, Philipp Zabel wrote: Hi Vivek, On Tue, 2017-04-04 at 16:09 +0530, Vivek Gautam wrote: [...] I'd prefer to mirror the gpiod API a little, and to have the number contained in the array structure, similar to struct gpio_descs: [...] Alright, i can update

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-05 Thread Vivek Gautam
Hi Philipp, On 04/04/2017 06:17 PM, Philipp Zabel wrote: Hi Vivek, On Tue, 2017-04-04 at 16:09 +0530, Vivek Gautam wrote: [...] I'd prefer to mirror the gpiod API a little, and to have the number contained in the array structure, similar to struct gpio_descs: [...] Alright, i can update

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-04 Thread Philipp Zabel
Hi Vivek, On Tue, 2017-04-04 at 16:09 +0530, Vivek Gautam wrote: [...] > > I'd prefer to mirror the gpiod API a little, and to have the number > > contained in the array structure, similar to struct gpio_descs: [...] > Alright, i can update this. > I took regulator_bulk interface as the

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-04 Thread Philipp Zabel
Hi Vivek, On Tue, 2017-04-04 at 16:09 +0530, Vivek Gautam wrote: [...] > > I'd prefer to mirror the gpiod API a little, and to have the number > > contained in the array structure, similar to struct gpio_descs: [...] > Alright, i can update this. > I took regulator_bulk interface as the

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-04 Thread Vivek Gautam
Hi Philipp, On 04/03/2017 10:06 PM, Philipp Zabel wrote: Hi Vivek, thank you for the patch series. A few comments below: I'd like to reduce the API surface a bit and include the counting and array allocation in the _get functions, if possible. Thank you for reviewing the patch. Please find

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-04 Thread Vivek Gautam
Hi Philipp, On 04/03/2017 10:06 PM, Philipp Zabel wrote: Hi Vivek, thank you for the patch series. A few comments below: I'd like to reduce the API surface a bit and include the counting and array allocation in the _get functions, if possible. Thank you for reviewing the patch. Please find

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-03 Thread Vivek Gautam
On 04/04/2017 09:44 AM, kbuild test robot wrote: Hi Vivek, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-03 Thread Vivek Gautam
On 04/04/2017 09:44 AM, kbuild test robot wrote: Hi Vivek, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-03 Thread kbuild test robot
Hi Vivek, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-03 Thread kbuild test robot
Hi Vivek, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-03 Thread kbuild test robot
Hi Vivek, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-03 Thread kbuild test robot
Hi Vivek, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-03 Thread Philipp Zabel
Hi Vivek, thank you for the patch series. A few comments below: I'd like to reduce the API surface a bit and include the counting and array allocation in the _get functions, if possible. On Mon, 2017-04-03 at 19:12 +0530, Vivek Gautam wrote: > Many devices may want to request a bunch of resets >

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-03 Thread Philipp Zabel
Hi Vivek, thank you for the patch series. A few comments below: I'd like to reduce the API surface a bit and include the counting and array allocation in the _get functions, if possible. On Mon, 2017-04-03 at 19:12 +0530, Vivek Gautam wrote: > Many devices may want to request a bunch of resets >

[PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-03 Thread Vivek Gautam
Many devices may want to request a bunch of resets and control them. So it's better to manage them as an array. Add APIs to _get(), _assert(), and _deassert() an array of reset_control. Cc: Philipp Zabel Signed-off-by: Vivek Gautam ---

[PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-03 Thread Vivek Gautam
Many devices may want to request a bunch of resets and control them. So it's better to manage them as an array. Add APIs to _get(), _assert(), and _deassert() an array of reset_control. Cc: Philipp Zabel Signed-off-by: Vivek Gautam --- Changes since v1: - New patch added to the series.