Re: [PATCH v2 3/3] HID: cp2112: fix broken gpio_direction_input callback

2017-11-10 Thread Jiri Kosina
On Fri, 10 Nov 2017, Sébastien Szymanski wrote: > When everything goes smoothly, ret is set to 0 which makes the function > to return EIO error. > > Fixes: 8e9faa15469e ("HID: cp2112: fix gpio-callback error handling") > Signed-off-by: Sébastien Szymanski > ---

Re: [PATCH v2 3/3] HID: cp2112: fix broken gpio_direction_input callback

2017-11-10 Thread Jiri Kosina
On Fri, 10 Nov 2017, Sébastien Szymanski wrote: > When everything goes smoothly, ret is set to 0 which makes the function > to return EIO error. > > Fixes: 8e9faa15469e ("HID: cp2112: fix gpio-callback error handling") > Signed-off-by: Sébastien Szymanski > --- > Changes in v2: > - rework

[PATCH v2 3/3] HID: cp2112: fix broken gpio_direction_input callback

2017-11-10 Thread Sébastien Szymanski
When everything goes smoothly, ret is set to 0 which makes the function to return EIO error. Fixes: 8e9faa15469e ("HID: cp2112: fix gpio-callback error handling") Signed-off-by: Sébastien Szymanski --- Changes in v2: - rework error handling to have only one

[PATCH v2 3/3] HID: cp2112: fix broken gpio_direction_input callback

2017-11-10 Thread Sébastien Szymanski
When everything goes smoothly, ret is set to 0 which makes the function to return EIO error. Fixes: 8e9faa15469e ("HID: cp2112: fix gpio-callback error handling") Signed-off-by: Sébastien Szymanski --- Changes in v2: - rework error handling to have only one exit path as suggested by Benjamin

Re: [PATCH v2 3/3] HID: cp2112: fix broken gpio_direction_input callback

2017-11-10 Thread Benjamin Tissoires
On Nov 10 2017 or thereabouts, Sébastien Szymanski wrote: > When everything goes smoothly, ret is set to 0 which makes the function > to return EIO error. > > Fixes: 8e9faa15469e ("HID: cp2112: fix gpio-callback error handling") > Signed-off-by: Sébastien Szymanski

Re: [PATCH v2 3/3] HID: cp2112: fix broken gpio_direction_input callback

2017-11-10 Thread Benjamin Tissoires
On Nov 10 2017 or thereabouts, Sébastien Szymanski wrote: > When everything goes smoothly, ret is set to 0 which makes the function > to return EIO error. > > Fixes: 8e9faa15469e ("HID: cp2112: fix gpio-callback error handling") > Signed-off-by: Sébastien Szymanski > --- > Changes in v2: > -