Re: [PATCH v2 3/4] i3c: master: svc: Add Silvaco I3C master driver

2020-12-28 Thread Miquel Raynal
Hi Boris, It's been quite some time since you made this review, but now that I am ready to send a new version, I think it is useful to answer your questions and remarks below which I pretty much all addressed with significant changes. Also adding Alexandre so he can smoothly get into this driver

Re: [PATCH v2 3/4] i3c: master: svc: Add Silvaco I3C master driver

2020-08-19 Thread Boris Brezillon
On Wed, 12 Aug 2020 16:13:11 +0200 Miquel Raynal wrote: > + > +#define SVC_I3C_MAX_DEVS 32 > + > +struct svc_i3c_cmd { > + u8 addr; > + bool rnw; > + u8 *in; > + const void *out; > + unsigned int len; > + unsigned int read_len; > + bool continued; > +}; > + > +struct

Re: [PATCH v2 3/4] i3c: master: svc: Add Silvaco I3C master driver

2020-08-12 Thread Miquel Raynal
Hi Conor, Rajeev, > +static int svc_i3c_master_handle_ibi(struct svc_i3c_master *master, > + struct i3c_dev_desc *dev) > +{ > + struct svc_i3c_i2c_dev_data *data = i3c_dev_get_master_data(dev); > + struct i3c_ibi_slot *slot; > + unsigned int count; > +

[PATCH v2 3/4] i3c: master: svc: Add Silvaco I3C master driver

2020-08-12 Thread Miquel Raynal
Add support for Silvaco I3C dual-role IP. The master role is supported in SDR mode only. I2C transfers have not been tested but are shared because they are so close to the I3C transfers in terms of registers configuration. Signed-off-by: Miquel Raynal --- Changes in v2: * Declared all the