Re: [PATCH v2 3/6] ACPI: AC: Replace acpi_driver with platform_driver

2023-10-09 Thread Rafael J. Wysocki
On Mon, Oct 9, 2023 at 3:04 PM Wilczynski, Michal wrote: > > > > On 10/9/2023 2:27 PM, Rafael J. Wysocki wrote: > > On Mon, Oct 9, 2023 at 10:40 AM Wilczynski, Michal > > wrote: > >> [cut] > >> Yeah we could add platform device without removing acpi device, and > >> yes that would introduce

Re: [PATCH v2 3/6] ACPI: AC: Replace acpi_driver with platform_driver

2023-10-09 Thread Wilczynski, Michal
On 10/9/2023 2:27 PM, Rafael J. Wysocki wrote: > On Mon, Oct 9, 2023 at 10:40 AM Wilczynski, Michal > wrote: >> >> Hi ! >> >> Thanks a lot for a review, to both of you ! :-) >> >> On 10/7/2023 12:43 PM, Rafael J. Wysocki wrote: >>> On Sat, Oct 7, 2023 at 12:41 PM Rafael J. Wysocki wrote:

Re: [PATCH v2 3/6] ACPI: AC: Replace acpi_driver with platform_driver

2023-10-09 Thread Rafael J. Wysocki
On Mon, Oct 9, 2023 at 10:40 AM Wilczynski, Michal wrote: > > > Hi ! > > Thanks a lot for a review, to both of you ! :-) > > On 10/7/2023 12:43 PM, Rafael J. Wysocki wrote: > > On Sat, Oct 7, 2023 at 12:41 PM Rafael J. Wysocki wrote: > >> On Sat, Oct 7, 2023 at 9:56 AM Andy Shevchenko > >>

Re: [PATCH v2 3/6] ACPI: AC: Replace acpi_driver with platform_driver

2023-10-09 Thread Wilczynski, Michal
Hi ! Thanks a lot for a review, to both of you ! :-) On 10/7/2023 12:43 PM, Rafael J. Wysocki wrote: > On Sat, Oct 7, 2023 at 12:41 PM Rafael J. Wysocki wrote: >> On Sat, Oct 7, 2023 at 9:56 AM Andy Shevchenko >> wrote: >>> On Fri, Oct 06, 2023 at 09:47:57PM +0200, Rafael J. Wysocki wrote:

Re: [PATCH v2 3/6] ACPI: AC: Replace acpi_driver with platform_driver

2023-10-07 Thread Rafael J. Wysocki
On Sat, Oct 7, 2023 at 12:41 PM Rafael J. Wysocki wrote: > > On Sat, Oct 7, 2023 at 9:56 AM Andy Shevchenko > wrote: > > > > On Fri, Oct 06, 2023 at 09:47:57PM +0200, Rafael J. Wysocki wrote: > > > On Fri, Oct 6, 2023 at 8:33 PM Michal Wilczynski > > > wrote: > > > > ... > > > > > > struct

Re: [PATCH v2 3/6] ACPI: AC: Replace acpi_driver with platform_driver

2023-10-07 Thread Rafael J. Wysocki
On Sat, Oct 7, 2023 at 9:56 AM Andy Shevchenko wrote: > > On Fri, Oct 06, 2023 at 09:47:57PM +0200, Rafael J. Wysocki wrote: > > On Fri, Oct 6, 2023 at 8:33 PM Michal Wilczynski > > wrote: > > ... > > > > struct acpi_ac { > > > struct power_supply *charger; > > > struct

Re: [PATCH v2 3/6] ACPI: AC: Replace acpi_driver with platform_driver

2023-10-07 Thread Andy Shevchenko
On Fri, Oct 06, 2023 at 09:47:57PM +0200, Rafael J. Wysocki wrote: > On Fri, Oct 6, 2023 at 8:33 PM Michal Wilczynski > wrote: ... > > struct acpi_ac { > > struct power_supply *charger; > > struct power_supply_desc charger_desc; > > - struct acpi_device *device; > > +

Re: [PATCH v2 3/6] ACPI: AC: Replace acpi_driver with platform_driver

2023-10-06 Thread Rafael J. Wysocki
On Fri, Oct 6, 2023 at 8:33 PM Michal Wilczynski wrote: > > AC driver uses struct acpi_driver incorrectly to register itself. This > is wrong as the instances of the ACPI devices are not meant to > be literal devices, they're supposed to describe ACPI entry of a > particular device. > > Use

Re: [PATCH v2 3/6] ACPI: AC: Replace acpi_driver with platform_driver

2023-10-06 Thread Andy Shevchenko
On Fri, Oct 06, 2023 at 08:30:52PM +0300, Michal Wilczynski wrote: > AC driver uses struct acpi_driver incorrectly to register itself. This > is wrong as the instances of the ACPI devices are not meant to > be literal devices, they're supposed to describe ACPI entry of a > particular device. > >

[PATCH v2 3/6] ACPI: AC: Replace acpi_driver with platform_driver

2023-10-06 Thread Michal Wilczynski
AC driver uses struct acpi_driver incorrectly to register itself. This is wrong as the instances of the ACPI devices are not meant to be literal devices, they're supposed to describe ACPI entry of a particular device. Use platform_driver instead of acpi_driver. In relevant places call platform