Re: [PATCH v2 6/6] x86: Fix thread_saved_pc()

2016-06-24 Thread Josh Poimboeuf
On Wed, Jun 22, 2016 at 12:27:43AM -0400, Brian Gerst wrote: > On Mon, Jun 20, 2016 at 12:01 PM, Josh Poimboeuf wrote: > > On Sat, Jun 18, 2016 at 04:56:18PM -0400, Brian Gerst wrote: > >> thread_saved_pc() was using a completely bogus method to get the return > >> address.

Re: [PATCH v2 6/6] x86: Fix thread_saved_pc()

2016-06-24 Thread Josh Poimboeuf
On Wed, Jun 22, 2016 at 12:27:43AM -0400, Brian Gerst wrote: > On Mon, Jun 20, 2016 at 12:01 PM, Josh Poimboeuf wrote: > > On Sat, Jun 18, 2016 at 04:56:18PM -0400, Brian Gerst wrote: > >> thread_saved_pc() was using a completely bogus method to get the return > >> address. Since switch_to() was

Re: [PATCH v2 6/6] x86: Fix thread_saved_pc()

2016-06-21 Thread Brian Gerst
On Mon, Jun 20, 2016 at 12:01 PM, Josh Poimboeuf wrote: > On Sat, Jun 18, 2016 at 04:56:18PM -0400, Brian Gerst wrote: >> thread_saved_pc() was using a completely bogus method to get the return >> address. Since switch_to() was previously inlined, there was no sane way >> to

Re: [PATCH v2 6/6] x86: Fix thread_saved_pc()

2016-06-21 Thread Brian Gerst
On Mon, Jun 20, 2016 at 12:01 PM, Josh Poimboeuf wrote: > On Sat, Jun 18, 2016 at 04:56:18PM -0400, Brian Gerst wrote: >> thread_saved_pc() was using a completely bogus method to get the return >> address. Since switch_to() was previously inlined, there was no sane way >> to know where on the

Re: [PATCH v2 6/6] x86: Fix thread_saved_pc()

2016-06-20 Thread Josh Poimboeuf
On Sat, Jun 18, 2016 at 04:56:18PM -0400, Brian Gerst wrote: > thread_saved_pc() was using a completely bogus method to get the return > address. Since switch_to() was previously inlined, there was no sane way > to know where on the stack the return address was stored. Now with the > frame of a

Re: [PATCH v2 6/6] x86: Fix thread_saved_pc()

2016-06-20 Thread Josh Poimboeuf
On Sat, Jun 18, 2016 at 04:56:18PM -0400, Brian Gerst wrote: > thread_saved_pc() was using a completely bogus method to get the return > address. Since switch_to() was previously inlined, there was no sane way > to know where on the stack the return address was stored. Now with the > frame of a

[PATCH v2 6/6] x86: Fix thread_saved_pc()

2016-06-18 Thread Brian Gerst
thread_saved_pc() was using a completely bogus method to get the return address. Since switch_to() was previously inlined, there was no sane way to know where on the stack the return address was stored. Now with the frame of a sleeping thread well defined, this can be implemented correctly.

[PATCH v2 6/6] x86: Fix thread_saved_pc()

2016-06-18 Thread Brian Gerst
thread_saved_pc() was using a completely bogus method to get the return address. Since switch_to() was previously inlined, there was no sane way to know where on the stack the return address was stored. Now with the frame of a sleeping thread well defined, this can be implemented correctly.