Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"

2017-03-16 Thread Greg Kroah-Hartman
On Thu, Mar 16, 2017 at 12:31:53PM +0300, Aleksey Makarov wrote: > > > On 03/16/2017 10:11 AM, Jayachandran C. wrote: > > Hi Greg, > > > > On Tue, Mar 14, 2017 at 9:44 PM, Sudeep Holla wrote: > >> > >> > >> On 01/03/17 15:23, Aleksey Makarov wrote: > >>> The original

Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"

2017-03-16 Thread Greg Kroah-Hartman
On Thu, Mar 16, 2017 at 12:31:53PM +0300, Aleksey Makarov wrote: > > > On 03/16/2017 10:11 AM, Jayachandran C. wrote: > > Hi Greg, > > > > On Tue, Mar 14, 2017 at 9:44 PM, Sudeep Holla wrote: > >> > >> > >> On 01/03/17 15:23, Aleksey Makarov wrote: > >>> The original patch makes the condition

Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"

2017-03-16 Thread Aleksey Makarov
On 03/16/2017 10:11 AM, Jayachandran C. wrote: > Hi Greg, > > On Tue, Mar 14, 2017 at 9:44 PM, Sudeep Holla wrote: >> >> >> On 01/03/17 15:23, Aleksey Makarov wrote: >>> The original patch makes the condition always true, so it is wrong. >>> >>> It masks (but not fixes)

Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"

2017-03-16 Thread Aleksey Makarov
On 03/16/2017 10:11 AM, Jayachandran C. wrote: > Hi Greg, > > On Tue, Mar 14, 2017 at 9:44 PM, Sudeep Holla wrote: >> >> >> On 01/03/17 15:23, Aleksey Makarov wrote: >>> The original patch makes the condition always true, so it is wrong. >>> >>> It masks (but not fixes) the bug described in

Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"

2017-03-16 Thread Jayachandran C.
Hi Greg, On Tue, Mar 14, 2017 at 9:44 PM, Sudeep Holla wrote: > > > On 01/03/17 15:23, Aleksey Makarov wrote: >> The original patch makes the condition always true, so it is wrong. >> >> It masks (but not fixes) the bug described in the commit message >> but introduces a

Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"

2017-03-16 Thread Jayachandran C.
Hi Greg, On Tue, Mar 14, 2017 at 9:44 PM, Sudeep Holla wrote: > > > On 01/03/17 15:23, Aleksey Makarov wrote: >> The original patch makes the condition always true, so it is wrong. >> >> It masks (but not fixes) the bug described in the commit message >> but introduces a regression (no console

Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"

2017-03-14 Thread Sudeep Holla
On 01/03/17 15:23, Aleksey Makarov wrote: > The original patch makes the condition always true, so it is wrong. > > It masks (but not fixes) the bug described in the commit message > but introduces a regression (no console is selected by SPCR) > in regular (no 'console=ttyAMA') case. > >

Re: [PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"

2017-03-14 Thread Sudeep Holla
On 01/03/17 15:23, Aleksey Makarov wrote: > The original patch makes the condition always true, so it is wrong. > > It masks (but not fixes) the bug described in the commit message > but introduces a regression (no console is selected by SPCR) > in regular (no 'console=ttyAMA') case. > >

[PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"

2017-03-01 Thread Aleksey Makarov
The original patch makes the condition always true, so it is wrong. It masks (but not fixes) the bug described in the commit message but introduces a regression (no console is selected by SPCR) in regular (no 'console=ttyAMA') case. s/||/&&/ would not fix the problem as the root cause was

[PATCH v3] Revert "tty: serial: pl011: add ttyAMA for matching pl011 console"

2017-03-01 Thread Aleksey Makarov
The original patch makes the condition always true, so it is wrong. It masks (but not fixes) the bug described in the commit message but introduces a regression (no console is selected by SPCR) in regular (no 'console=ttyAMA') case. s/||/&&/ would not fix the problem as the root cause was