Re: [PATCH v3] drm/rockchip: get rid of rockchip_drm_crtc_mode_config

2016-04-20 Thread John Keeping
On Wed, 20 Apr 2016 10:41:42 +0800, Mark Yao wrote: > We need to take care of the vop status when use > rockchip_drm_crtc_mode_config, if vop is disabled, > the function would failed, that is terrible. > > Save output_type and output_mode into rockchip_crtc_state, > it's nice to make them into

Re: [PATCH v3] drm/rockchip: get rid of rockchip_drm_crtc_mode_config

2016-04-20 Thread John Keeping
On Wed, 20 Apr 2016 10:41:42 +0800, Mark Yao wrote: > We need to take care of the vop status when use > rockchip_drm_crtc_mode_config, if vop is disabled, > the function would failed, that is terrible. > > Save output_type and output_mode into rockchip_crtc_state, > it's nice to make them into

[PATCH v3] drm/rockchip: get rid of rockchip_drm_crtc_mode_config

2016-04-19 Thread Mark Yao
We need to take care of the vop status when use rockchip_drm_crtc_mode_config, if vop is disabled, the function would failed, that is terrible. Save output_type and output_mode into rockchip_crtc_state, it's nice to make them into atomic. Signed-off-by: Mark Yao ---

[PATCH v3] drm/rockchip: get rid of rockchip_drm_crtc_mode_config

2016-04-19 Thread Mark Yao
We need to take care of the vop status when use rockchip_drm_crtc_mode_config, if vop is disabled, the function would failed, that is terrible. Save output_type and output_mode into rockchip_crtc_state, it's nice to make them into atomic. Signed-off-by: Mark Yao --- Changes in v3: - foget