Re: [PATCH v3] gpio: UniPhier: add driver for UniPhier GPIO controller

On Fri, May 20, 2016 at 6:30 AM, Masahiro Yamada wrote: > So, I'd like to know the recommended driver coding style > based on 4.7-rc1. Sure, best is to look at other recently added drivers I guess. > Diving into the git-log so far, I came up the following list: >

Re: [PATCH v3] gpio: UniPhier: add driver for UniPhier GPIO controller

On Fri, May 20, 2016 at 6:30 AM, Masahiro Yamada wrote: > So, I'd like to know the recommended driver coding style > based on 4.7-rc1. Sure, best is to look at other recently added drivers I guess. > Diving into the git-log so far, I came up the following list: > > [1] The "dev" member of

Re: [PATCH v3] gpio: UniPhier: add driver for UniPhier GPIO controller

Hi Linus, 2015-07-16 16:48 GMT+09:00 Masahiro Yamada : > Hi Linus, > > OK, I will do it in v4. I has been away from my GPIO driver upstreaming for a long time for some reason. I sent v3 ten months ago. http://patchwork.ozlabs.org/patch/494860/ In the

Re: [PATCH v3] gpio: UniPhier: add driver for UniPhier GPIO controller

Hi Linus, 2015-07-16 16:48 GMT+09:00 Masahiro Yamada : > Hi Linus, > > OK, I will do it in v4. I has been away from my GPIO driver upstreaming for a long time for some reason. I sent v3 ten months ago. http://patchwork.ozlabs.org/patch/494860/ In the meantime, there have been various

Re: [PATCH v3] gpio: UniPhier: add driver for UniPhier GPIO controller

Hi Linus, 2015-07-16 16:42 GMT+09:00 Linus Walleij : > On Thu, Jul 16, 2015 at 9:35 AM, Masahiro Yamada > wrote: >> 2015-07-16 16:07 GMT+09:00 Linus Walleij : > ngpio == 248 for some SoCs, and ngpio == 136 for some, etc. >>> >>> That is the wrong way to handle different SoC. That

Re: [PATCH v3] gpio: UniPhier: add driver for UniPhier GPIO controller

On Thu, Jul 16, 2015 at 9:35 AM, Masahiro Yamada wrote: > 2015-07-16 16:07 GMT+09:00 Linus Walleij : >>> ngpio == 248 for some SoCs, >>> and ngpio == 136 for some, etc. >> >> That is the wrong way to handle different SoC. That should be handled >> by different compatible strings, and then you

Re: [PATCH v3] gpio: UniPhier: add driver for UniPhier GPIO controller

Hi Linus, 2015-07-16 16:07 GMT+09:00 Linus Walleij : > On Thu, Jul 16, 2015 at 5:44 AM, Masahiro Yamada > wrote: >> 2015-07-15 23:15 GMT+09:00 Linus Walleij : > + for (i = 0; i < chip->ngpio; i += UNIPHIER_GPIO_PORTS_PER_BANK) { + bank = i /

Re: [PATCH v3] gpio: UniPhier: add driver for UniPhier GPIO controller

On Thu, Jul 16, 2015 at 5:44 AM, Masahiro Yamada wrote: > 2015-07-15 23:15 GMT+09:00 Linus Walleij : >>> + for (i = 0; i < chip->ngpio; i += UNIPHIER_GPIO_PORTS_PER_BANK) { >>> + bank = i / UNIPHIER_GPIO_PORTS_PER_BANK; >>> + shift = i % BITS_PER_LONG; >>> +

Re: [PATCH v3] gpio: UniPhier: add driver for UniPhier GPIO controller

On Thu, Jul 16, 2015 at 5:44 AM, Masahiro Yamada yamada.masah...@socionext.com wrote: 2015-07-15 23:15 GMT+09:00 Linus Walleij linus.wall...@linaro.org: + for (i = 0; i chip-ngpio; i += UNIPHIER_GPIO_PORTS_PER_BANK) { + bank = i / UNIPHIER_GPIO_PORTS_PER_BANK; +

Re: [PATCH v3] gpio: UniPhier: add driver for UniPhier GPIO controller

Hi Linus, 2015-07-16 16:42 GMT+09:00 Linus Walleij linus.wall...@linaro.org: On Thu, Jul 16, 2015 at 9:35 AM, Masahiro Yamada yamada.masah...@socionext.com wrote: 2015-07-16 16:07 GMT+09:00 Linus Walleij linus.wall...@linaro.org: ngpio == 248 for some SoCs, and ngpio == 136 for some, etc.

Re: [PATCH v3] gpio: UniPhier: add driver for UniPhier GPIO controller

Hi Linus, 2015-07-16 16:07 GMT+09:00 Linus Walleij linus.wall...@linaro.org: On Thu, Jul 16, 2015 at 5:44 AM, Masahiro Yamada yamada.masah...@socionext.com wrote: 2015-07-15 23:15 GMT+09:00 Linus Walleij linus.wall...@linaro.org: + for (i = 0; i chip-ngpio; i +=

Re: [PATCH v3] gpio: UniPhier: add driver for UniPhier GPIO controller

On Thu, Jul 16, 2015 at 9:35 AM, Masahiro Yamada yamada.masah...@socionext.com wrote: 2015-07-16 16:07 GMT+09:00 Linus Walleij linus.wall...@linaro.org: ngpio == 248 for some SoCs, and ngpio == 136 for some, etc. That is the wrong way to handle different SoC. That should be handled by

Re: [PATCH v3] gpio: UniPhier: add driver for UniPhier GPIO controller

Hi Linus, 2015-07-15 23:15 GMT+09:00 Linus Walleij : > On Tue, Jul 14, 2015 at 4:43 AM, Masahiro Yamada > wrote: > >> This GPIO controller device is used on UniPhier SoCs. >> >> Signed-off-by: Masahiro Yamada >> --- >> >> Changes in v3: >> - Use module_platform_driver() >> >> Changes in v2:

Re: [PATCH v3] gpio: UniPhier: add driver for UniPhier GPIO controller

On Tue, Jul 14, 2015 at 4:43 AM, Masahiro Yamada wrote: > This GPIO controller device is used on UniPhier SoCs. > > Signed-off-by: Masahiro Yamada > --- > > Changes in v3: > - Use module_platform_driver() > > Changes in v2: > - Fix typos in the comment block OK why no device tree bindings?

Re: [PATCH v3] gpio: UniPhier: add driver for UniPhier GPIO controller

Hi Linus, 2015-07-15 23:15 GMT+09:00 Linus Walleij linus.wall...@linaro.org: On Tue, Jul 14, 2015 at 4:43 AM, Masahiro Yamada yamada.masah...@socionext.com wrote: This GPIO controller device is used on UniPhier SoCs. Signed-off-by: Masahiro Yamada yamada.masah...@socionext.com ---

Re: [PATCH v3] gpio: UniPhier: add driver for UniPhier GPIO controller

On Tue, Jul 14, 2015 at 4:43 AM, Masahiro Yamada yamada.masah...@socionext.com wrote: This GPIO controller device is used on UniPhier SoCs. Signed-off-by: Masahiro Yamada yamada.masah...@socionext.com --- Changes in v3: - Use module_platform_driver() Changes in v2: - Fix typos in

[PATCH v3] gpio: UniPhier: add driver for UniPhier GPIO controller

This GPIO controller device is used on UniPhier SoCs. Signed-off-by: Masahiro Yamada --- Changes in v3: - Use module_platform_driver() Changes in v2: - Fix typos in the comment block drivers/gpio/Kconfig | 6 + drivers/gpio/Makefile| 1 + drivers/gpio/gpio-uniphier.c

[PATCH v3] gpio: UniPhier: add driver for UniPhier GPIO controller

This GPIO controller device is used on UniPhier SoCs. Signed-off-by: Masahiro Yamada yamada.masah...@socionext.com --- Changes in v3: - Use module_platform_driver() Changes in v2: - Fix typos in the comment block drivers/gpio/Kconfig | 6 + drivers/gpio/Makefile| 1 +