Re: [PATCH v3 06/11] drm: Use state helper instead of plane state pointer in atomic_check

2021-02-23 Thread Maxime Ripard
Hi Thomas, On Mon, Feb 22, 2021 at 10:12:49AM +0100, Thomas Zimmermann wrote: > Am 19.02.21 um 13:00 schrieb Maxime Ripard: > > Many drivers reference the plane->state pointer in order to get the > > current plane state in their atomic_check hook, which would be the old > > plane state in the

Re: [PATCH v3 06/11] drm: Use state helper instead of plane state pointer in atomic_check

2021-02-22 Thread Thomas Zimmermann
Am 19.02.21 um 13:00 schrieb Maxime Ripard: Many drivers reference the plane->state pointer in order to get the current plane state in their atomic_check hook, which would be the old plane state in the global atomic state since _swap_state hasn't happened when atomic_check is run. Use the

[PATCH v3 06/11] drm: Use state helper instead of plane state pointer in atomic_check

2021-02-19 Thread Maxime Ripard
Many drivers reference the plane->state pointer in order to get the current plane state in their atomic_check hook, which would be the old plane state in the global atomic state since _swap_state hasn't happened when atomic_check is run. Use the drm_atomic_get_old_plane_state helper to get that