Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

Hi, Greg Kroah-Hartman writes: > On Wed, Apr 06, 2016 at 01:19:04PM +0300, Felipe Balbi wrote: >> > What happened to getting internal help in designing this api? This >> > shouldn't be my job :) >> >> I looked at this Baolu but, at least to me, it's unclear what

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

Hi, Greg Kroah-Hartman writes: > On Wed, Apr 06, 2016 at 01:19:04PM +0300, Felipe Balbi wrote: >> > What happened to getting internal help in designing this api? This >> > shouldn't be my job :) >> >> I looked at this Baolu but, at least to me, it's unclear what you're >> hinting here. Sure,

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

On Wed, Apr 06, 2016 at 01:19:04PM +0300, Felipe Balbi wrote: > > What happened to getting internal help in designing this api? This > > shouldn't be my job :) > > I looked at this Baolu but, at least to me, it's unclear what you're > hinting here. Sure, the API is a bit odd in that we register

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

On Wed, Apr 06, 2016 at 01:19:04PM +0300, Felipe Balbi wrote: > > What happened to getting internal help in designing this api? This > > shouldn't be my job :) > > I looked at this Baolu but, at least to me, it's unclear what you're > hinting here. Sure, the API is a bit odd in that we register

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

Hello. On 4/6/2016 9:44 AM, Lu Baolu wrote: +struct intel_mux_dev { + struct device *dev; + char*extcon_name; + char*cable_name; + int (*cable_set_cb)(struct intel_mux_dev *mux); + int (*cable_unset_cb)(struct

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

Hello. On 4/6/2016 9:44 AM, Lu Baolu wrote: +struct intel_mux_dev { + struct device *dev; + char*extcon_name; + char*cable_name; + int (*cable_set_cb)(struct intel_mux_dev *mux); + int (*cable_unset_cb)(struct

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

Hi, Greg Kroah-Hartman writes: > On Wed, Apr 06, 2016 at 02:44:55PM +0800, Lu Baolu wrote: >> Hi, >> >> On 03/14/2016 11:27 AM, Greg Kroah-Hartman wrote: >> > On Mon, Mar 14, 2016 at 09:09:22AM +0800, Lu Baolu wrote: >> >> On 03/11/2016 08:06 AM, Greg Kroah-Hartman

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

Hi, Greg Kroah-Hartman writes: > On Wed, Apr 06, 2016 at 02:44:55PM +0800, Lu Baolu wrote: >> Hi, >> >> On 03/14/2016 11:27 AM, Greg Kroah-Hartman wrote: >> > On Mon, Mar 14, 2016 at 09:09:22AM +0800, Lu Baolu wrote: >> >> On 03/11/2016 08:06 AM, Greg Kroah-Hartman wrote: >> >>> On Tue, Mar

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

Hi, Greg Kroah-Hartman writes: >> On 03/11/2016 07:57 AM, Greg Kroah-Hartman wrote: >> > On Thu, Mar 10, 2016 at 01:39:43PM +0100, Oliver Neukum wrote: >> >> On Tue, 2016-03-08 at 15:53 +0800, Lu Baolu wrote: >> >> >> >>> diff --git

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

Hi, Greg Kroah-Hartman writes: >> On 03/11/2016 07:57 AM, Greg Kroah-Hartman wrote: >> > On Thu, Mar 10, 2016 at 01:39:43PM +0100, Oliver Neukum wrote: >> >> On Tue, 2016-03-08 at 15:53 +0800, Lu Baolu wrote: >> >> >> >>> diff --git a/Documentation/ABI/testing/sysfs-bus-platform >> >>>

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

On Wed, Apr 06, 2016 at 01:58:52PM +0800, Lu Baolu wrote: > Hi, > > On 03/11/2016 07:57 AM, Greg Kroah-Hartman wrote: > > On Thu, Mar 10, 2016 at 01:39:43PM +0100, Oliver Neukum wrote: > >> On Tue, 2016-03-08 at 15:53 +0800, Lu Baolu wrote: > >> > >>> diff --git

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

On Wed, Apr 06, 2016 at 01:58:52PM +0800, Lu Baolu wrote: > Hi, > > On 03/11/2016 07:57 AM, Greg Kroah-Hartman wrote: > > On Thu, Mar 10, 2016 at 01:39:43PM +0100, Oliver Neukum wrote: > >> On Tue, 2016-03-08 at 15:53 +0800, Lu Baolu wrote: > >> > >>> diff --git

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

On Wed, Apr 06, 2016 at 02:44:55PM +0800, Lu Baolu wrote: > Hi, > > On 03/14/2016 11:27 AM, Greg Kroah-Hartman wrote: > > On Mon, Mar 14, 2016 at 09:09:22AM +0800, Lu Baolu wrote: > >> On 03/11/2016 08:06 AM, Greg Kroah-Hartman wrote: > >>> On Tue, Mar 08, 2016 at 03:53:44PM +0800, Lu Baolu

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

On Wed, Apr 06, 2016 at 02:44:55PM +0800, Lu Baolu wrote: > Hi, > > On 03/14/2016 11:27 AM, Greg Kroah-Hartman wrote: > > On Mon, Mar 14, 2016 at 09:09:22AM +0800, Lu Baolu wrote: > >> On 03/11/2016 08:06 AM, Greg Kroah-Hartman wrote: > >>> On Tue, Mar 08, 2016 at 03:53:44PM +0800, Lu Baolu

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

Hi, On 03/14/2016 11:27 AM, Greg Kroah-Hartman wrote: > On Mon, Mar 14, 2016 at 09:09:22AM +0800, Lu Baolu wrote: >> On 03/11/2016 08:06 AM, Greg Kroah-Hartman wrote: >>> On Tue, Mar 08, 2016 at 03:53:44PM +0800, Lu Baolu wrote: +struct intel_mux_dev { + struct device *dev; +

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

Hi, On 03/14/2016 11:27 AM, Greg Kroah-Hartman wrote: > On Mon, Mar 14, 2016 at 09:09:22AM +0800, Lu Baolu wrote: >> On 03/11/2016 08:06 AM, Greg Kroah-Hartman wrote: >>> On Tue, Mar 08, 2016 at 03:53:44PM +0800, Lu Baolu wrote: +struct intel_mux_dev { + struct device *dev; +

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

Hi, On 03/11/2016 07:57 AM, Greg Kroah-Hartman wrote: > On Thu, Mar 10, 2016 at 01:39:43PM +0100, Oliver Neukum wrote: >> On Tue, 2016-03-08 at 15:53 +0800, Lu Baolu wrote: >> >>> diff --git a/Documentation/ABI/testing/sysfs-bus-platform >>> b/Documentation/ABI/testing/sysfs-bus-platform >>>

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

Hi, On 03/11/2016 07:57 AM, Greg Kroah-Hartman wrote: > On Thu, Mar 10, 2016 at 01:39:43PM +0100, Oliver Neukum wrote: >> On Tue, 2016-03-08 at 15:53 +0800, Lu Baolu wrote: >> >>> diff --git a/Documentation/ABI/testing/sysfs-bus-platform >>> b/Documentation/ABI/testing/sysfs-bus-platform >>>

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

On 03/14/2016 11:27 AM, Greg Kroah-Hartman wrote: > On Mon, Mar 14, 2016 at 09:09:22AM +0800, Lu Baolu wrote: >> On 03/11/2016 08:06 AM, Greg Kroah-Hartman wrote: >>> On Tue, Mar 08, 2016 at 03:53:44PM +0800, Lu Baolu wrote: +struct intel_mux_dev { + struct device *dev; + char

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

On 03/14/2016 11:27 AM, Greg Kroah-Hartman wrote: > On Mon, Mar 14, 2016 at 09:09:22AM +0800, Lu Baolu wrote: >> On 03/11/2016 08:06 AM, Greg Kroah-Hartman wrote: >>> On Tue, Mar 08, 2016 at 03:53:44PM +0800, Lu Baolu wrote: +struct intel_mux_dev { + struct device *dev; + char

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

On Mon, Mar 14, 2016 at 09:09:22AM +0800, Lu Baolu wrote: > On 03/11/2016 08:06 AM, Greg Kroah-Hartman wrote: > > On Tue, Mar 08, 2016 at 03:53:44PM +0800, Lu Baolu wrote: > >> +struct intel_mux_dev { > >> + struct device *dev; > >> + char*extcon_name; > >> + char

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

On Mon, Mar 14, 2016 at 09:09:22AM +0800, Lu Baolu wrote: > On 03/11/2016 08:06 AM, Greg Kroah-Hartman wrote: > > On Tue, Mar 08, 2016 at 03:53:44PM +0800, Lu Baolu wrote: > >> +struct intel_mux_dev { > >> + struct device *dev; > >> + char*extcon_name; > >> + char

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

Hi, On 03/11/2016 08:06 AM, Greg Kroah-Hartman wrote: > On Tue, Mar 08, 2016 at 03:53:44PM +0800, Lu Baolu wrote: >> Several Intel PCHs and SOCs have an internal mux that is used to >> share one USB port between device controller and host controller. >> >> A usb port mux could be abstracted as

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

Hi, On 03/11/2016 08:06 AM, Greg Kroah-Hartman wrote: > On Tue, Mar 08, 2016 at 03:53:44PM +0800, Lu Baolu wrote: >> Several Intel PCHs and SOCs have an internal mux that is used to >> share one USB port between device controller and host controller. >> >> A usb port mux could be abstracted as

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

On 03/11/2016 07:57 AM, Greg Kroah-Hartman wrote: > On Thu, Mar 10, 2016 at 01:39:43PM +0100, Oliver Neukum wrote: >> On Tue, 2016-03-08 at 15:53 +0800, Lu Baolu wrote: >> >>> diff --git a/Documentation/ABI/testing/sysfs-bus-platform >>> b/Documentation/ABI/testing/sysfs-bus-platform >>> index

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

On 03/11/2016 07:57 AM, Greg Kroah-Hartman wrote: > On Thu, Mar 10, 2016 at 01:39:43PM +0100, Oliver Neukum wrote: >> On Tue, 2016-03-08 at 15:53 +0800, Lu Baolu wrote: >> >>> diff --git a/Documentation/ABI/testing/sysfs-bus-platform >>> b/Documentation/ABI/testing/sysfs-bus-platform >>> index

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

On Tue, Mar 08, 2016 at 03:53:44PM +0800, Lu Baolu wrote: > Several Intel PCHs and SOCs have an internal mux that is used to > share one USB port between device controller and host controller. > > A usb port mux could be abstracted as the following elements: > 1) mux state: HOST or PERIPHERAL; >

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

On Tue, Mar 08, 2016 at 03:53:44PM +0800, Lu Baolu wrote: > Several Intel PCHs and SOCs have an internal mux that is used to > share one USB port between device controller and host controller. > > A usb port mux could be abstracted as the following elements: > 1) mux state: HOST or PERIPHERAL; >

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

On Thu, Mar 10, 2016 at 01:39:43PM +0100, Oliver Neukum wrote: > On Tue, 2016-03-08 at 15:53 +0800, Lu Baolu wrote: > > > diff --git a/Documentation/ABI/testing/sysfs-bus-platform > > b/Documentation/ABI/testing/sysfs-bus-platform > > index 5172a61..a2261cb 100644 > > ---

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

On Thu, Mar 10, 2016 at 01:39:43PM +0100, Oliver Neukum wrote: > On Tue, 2016-03-08 at 15:53 +0800, Lu Baolu wrote: > > > diff --git a/Documentation/ABI/testing/sysfs-bus-platform > > b/Documentation/ABI/testing/sysfs-bus-platform > > index 5172a61..a2261cb 100644 > > ---

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

On Tue, 2016-03-08 at 15:53 +0800, Lu Baolu wrote: > diff --git a/Documentation/ABI/testing/sysfs-bus-platform > b/Documentation/ABI/testing/sysfs-bus-platform > index 5172a61..a2261cb 100644 > --- a/Documentation/ABI/testing/sysfs-bus-platform > +++

Re: [PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

On Tue, 2016-03-08 at 15:53 +0800, Lu Baolu wrote: > diff --git a/Documentation/ABI/testing/sysfs-bus-platform > b/Documentation/ABI/testing/sysfs-bus-platform > index 5172a61..a2261cb 100644 > --- a/Documentation/ABI/testing/sysfs-bus-platform > +++

[PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

Several Intel PCHs and SOCs have an internal mux that is used to share one USB port between device controller and host controller. A usb port mux could be abstracted as the following elements: 1) mux state: HOST or PERIPHERAL; 2) an extcon cable which triggers the change of mux state between

[PATCH v3 3/7] usb: mux: add common code for Intel dual role port mux

Several Intel PCHs and SOCs have an internal mux that is used to share one USB port between device controller and host controller. A usb port mux could be abstracted as the following elements: 1) mux state: HOST or PERIPHERAL; 2) an extcon cable which triggers the change of mux state between