On 08/12/2019 05:01 PM, Bartlomiej Zolnierkiewicz wrote:
>> Unfortunately, pata_buddha_exit() is void, and thus can't fail. According to
>> Documentation/kernel-hacking/hacking.rst this is by design.
>
> You are of course right and the example code is broken
> (+ I need more caffeine).
Hey!
On 8/12/19 4:26 PM, Max Staudt wrote:
> On 08/12/2019 02:15 PM, Bartlomiej Zolnierkiewicz wrote:
>>> What's a good way to do that, given that we now have module_exit()> defined
>>> and an exit function is void?
>>
>> What about something like this:
>>
>> static bool xsurf_present;
>> ...
>>
On 08/12/2019 02:15 PM, Bartlomiej Zolnierkiewicz wrote:
>> What's a good way to do that, given that we now have module_exit()> defined
>> and an exit function is void?
>
> What about something like this:
>
> static bool xsurf_present;
> ...
> static int __init pata_buddha_late_init(void)
> ...
On 8/12/19 12:55 PM, Max Staudt wrote:
> Hi Bartlomiej,
>
> Thanks for your feedback!
Hi Max,
> On 08/12/2019 12:42 PM, Bartlomiej Zolnierkiewicz wrote:
>>
>> ide/buddha driver cannot be unloaded currently (it lacks module_exit()).
>>
>> [... snip ...]
>>
>> It should work exactly like the
Hi Bartlomiej,
Thanks for your feedback!
On 08/12/2019 12:42 PM, Bartlomiej Zolnierkiewicz wrote:
>
> ide/buddha driver cannot be unloaded currently (it lacks module_exit()).
>
> [... snip ...]
>
> It should work exactly like the old code in case of X-Surf,
> what do we need to release?
So
On 8/11/19 9:28 PM, Max Staudt wrote:
> Replying to my own patch with two more questions:
>
>
> On 08/11/2019 05:36 PM, Max Staudt wrote:
>> -/* allocate host */
>> -host = ata_host_alloc(>dev, nr_ports);
>
> Actually, this is an issue even the existing pata_buddha
Replying to my own patch with two more questions:
On 08/11/2019 05:36 PM, Max Staudt wrote:
> - /* allocate host */
> - host = ata_host_alloc(>dev, nr_ports);
Actually, this is an issue even the existing pata_buddha has: ata_host_alloc()
will dev_set_drvdata(dev, host)
Hi all,
Thank you for your reviews. I hope this patch fixes all issues that have been
raised. In case I've missed something, please let me know.
Unfortunately I can't test the X-Surf part, as I don't own that board. I would
be grateful for extra careful review of that part.
Max
Up until now, the pata_buddha driver would only check for cards on
initcall time. Now, the kernel will call its probe function as soon
as a compatible card is detected.
v4: Cleap up pata_buddha_probe() by using ent->driver_data,
Support X-Surf via late_initcall()
v3: Clean up devm_*,
9 matches
Mail list logo
