Re: [PATCH v4 1/2] mtd: spinand: micron: Generalize the function and structure names

2020-09-28 Thread Boris Brezillon
On Mon, 28 Sep 2020 18:21:59 +0200 Miquel Raynal wrote: > Hi Boris, > > Boris Brezillon wrote on Mon, 28 Sep > 2020 18:03:43 +0200: > > > On Mon, 28 Sep 2020 17:50:05 +0200 > > Miquel Raynal wrote: > > > > > > > The way OOB > > > > > bytes are organized do not seem relevant to me, I think

Re: [PATCH v4 1/2] mtd: spinand: micron: Generalize the function and structure names

2020-09-28 Thread Miquel Raynal
Hi Boris, Boris Brezillon wrote on Mon, 28 Sep 2020 18:03:43 +0200: > On Mon, 28 Sep 2020 17:50:05 +0200 > Miquel Raynal wrote: > > > > > The way OOB > > > > bytes are organized do not seem relevant to me, I think i prefer the > > > > "_4_/_8_" naming,even if it's not very explicit. > >

Re: [PATCH v4 1/2] mtd: spinand: micron: Generalize the function and structure names

2020-09-28 Thread Boris Brezillon
On Mon, 28 Sep 2020 17:50:05 +0200 Miquel Raynal wrote: > > > The way OOB > > > bytes are organized do not seem relevant to me, I think i prefer the > > > "_4_/_8_" naming,even if it's not very explicit. > > > > The ECC strength doesn't say anything about the scheme used for ECC > > bytes

Re: [PATCH v4 1/2] mtd: spinand: micron: Generalize the function and structure names

2020-09-28 Thread Miquel Raynal
Boris Brezillon wrote on Mon, 28 Sep 2020 17:45:05 +0200: > On Mon, 28 Sep 2020 16:55:28 +0200 > Miquel Raynal wrote: > > > > IMHO, grouped means, ecc bytes are at continuous address, where as > > > interleaved means ecc bytes splitted into multiple addresses > > > > I don't like the

Re: [PATCH v4 1/2] mtd: spinand: micron: Generalize the function and structure names

2020-09-28 Thread Boris Brezillon
On Mon, 28 Sep 2020 16:55:28 +0200 Miquel Raynal wrote: > > IMHO, grouped means, ecc bytes are at continuous address, where as > > interleaved means ecc bytes splitted into multiple addresses > > I don't like the name. Interleaved means that there are OOB bytes > stored in the data section,

Re: [PATCH v4 1/2] mtd: spinand: micron: Generalize the function and structure names

2020-09-28 Thread Miquel Raynal
Hi Thirumalesha, Thirumalesha N wrote on Sun, 20 Sep 2020 22:38:53 +0800: > Hi Miquèl, > > I adopted these changes as per the Boris Brezillon comments > > On Tue, Sep 15, 2020 at 4:13 PM Miquel Raynal > wrote: > > > Hi Thirumalesha, > > > > Thirumalesha Narasimhappa wrote on Mon, 14 > >

Re: [PATCH v4 1/2] mtd: spinand: micron: Generalize the function and structure names

2020-09-15 Thread Miquel Raynal
Hi Thirumalesha, Thirumalesha Narasimhappa wrote on Mon, 14 Sep 2020 00:15:32 +0800: > Rename the oob structure and read/write/update function names to > a generic names > > Signed-off-by: Thirumalesha Narasimhappa > --- > drivers/mtd/nand/spi/micron.c | 80

[PATCH v4 1/2] mtd: spinand: micron: Generalize the function and structure names

2020-09-13 Thread Thirumalesha Narasimhappa
Rename the oob structure and read/write/update function names to a generic names Signed-off-by: Thirumalesha Narasimhappa --- drivers/mtd/nand/spi/micron.c | 80 +-- 1 file changed, 40 insertions(+), 40 deletions(-) diff --git a/drivers/mtd/nand/spi/micron.c