Re: [PATCH v5] tools/perf: Fix the mask in regs_dump__printf and print_sample_iregs

2016-07-11 Thread Madhavan Srinivasan
Hi Arnaldo, Any updates for this fix. Kindly let me know. Maddy On Tuesday 28 June 2016 02:24 PM, Jiri Olsa wrote: > On Thu, Jun 23, 2016 at 11:19:27AM +0530, Madhavan Srinivasan wrote: > > SNIP > >> Changelog v1: >> 1)updated commit message and patch subject >> 2)Add the fix to

Re: [PATCH v5] tools/perf: Fix the mask in regs_dump__printf and print_sample_iregs

2016-07-11 Thread Madhavan Srinivasan
Hi Arnaldo, Any updates for this fix. Kindly let me know. Maddy On Tuesday 28 June 2016 02:24 PM, Jiri Olsa wrote: > On Thu, Jun 23, 2016 at 11:19:27AM +0530, Madhavan Srinivasan wrote: > > SNIP > >> Changelog v1: >> 1)updated commit message and patch subject >> 2)Add the fix to

Re: [PATCH v5] tools/perf: Fix the mask in regs_dump__printf and print_sample_iregs

2016-06-28 Thread Jiri Olsa
On Thu, Jun 23, 2016 at 11:19:27AM +0530, Madhavan Srinivasan wrote: SNIP > > Changelog v1: > 1)updated commit message and patch subject > 2)Add the fix to print_sample_iregs() in builtin-script.c > > tools/include/linux/bitmap.h | 2 ++ > tools/lib/bitmap.c | 18 ++

Re: [PATCH v5] tools/perf: Fix the mask in regs_dump__printf and print_sample_iregs

2016-06-28 Thread Jiri Olsa
On Thu, Jun 23, 2016 at 11:19:27AM +0530, Madhavan Srinivasan wrote: SNIP > > Changelog v1: > 1)updated commit message and patch subject > 2)Add the fix to print_sample_iregs() in builtin-script.c > > tools/include/linux/bitmap.h | 2 ++ > tools/lib/bitmap.c | 18 ++

[PATCH v5] tools/perf: Fix the mask in regs_dump__printf and print_sample_iregs

2016-06-22 Thread Madhavan Srinivasan
When decoding the perf_regs mask in regs_dump__printf(), we loop through the mask using find_first_bit and find_next_bit functions. "mask" is of type "u64", but sent as a "unsigned long *" to lib functions along with sizeof(). While the exisitng code works fine in most of the case, the logic is

[PATCH v5] tools/perf: Fix the mask in regs_dump__printf and print_sample_iregs

2016-06-22 Thread Madhavan Srinivasan
When decoding the perf_regs mask in regs_dump__printf(), we loop through the mask using find_first_bit and find_next_bit functions. "mask" is of type "u64", but sent as a "unsigned long *" to lib functions along with sizeof(). While the exisitng code works fine in most of the case, the logic is