Re: [PATCH v5 11/34] function_graph: Have the instances use their own ftrace_ops for filtering

2024-01-11 Thread Google
On Mon, 8 Jan 2024 15:03:21 + Mark Rutland wrote: > On Mon, Jan 08, 2024 at 02:21:03PM +, Mark Rutland wrote: > > On Mon, Jan 08, 2024 at 12:25:55PM +, Mark Rutland wrote: > > > We also have HAVE_FUNCTION_GRAPH_RET_ADDR_PTR, but since the return > > > address is > > > not on the

Re: [PATCH v5 11/34] function_graph: Have the instances use their own ftrace_ops for filtering

2024-01-11 Thread Google
Hi Mark, On Thu, 11 Jan 2024 11:01:56 + Mark Rutland wrote: > On Thu, Jan 11, 2024 at 11:15:33AM +0900, Masami Hiramatsu wrote: > > Hi Mark, > > > > Thanks for the investigation. > > Hi! > > As a heads-up, I already figured out the problem and sent a fixup at: > >

Re: [PATCH v5 11/34] function_graph: Have the instances use their own ftrace_ops for filtering

2024-01-11 Thread Mark Rutland
On Thu, Jan 11, 2024 at 11:15:33AM +0900, Masami Hiramatsu wrote: > Hi Mark, > > Thanks for the investigation. Hi! As a heads-up, I already figured out the problem and sent a fixup at: https://lore.kernel.org/lkml/ZZwEz8HsTa2IZE3L@FVFF77S0Q05N/ ... and a more refined fix at:

Re: [PATCH v5 11/34] function_graph: Have the instances use their own ftrace_ops for filtering

2024-01-10 Thread Google
Hi Mark, Thanks for the investigation. On Mon, 8 Jan 2024 12:25:55 + Mark Rutland wrote: > Hi, > > There's a bit more of an info-dump below; I'll go try to dump the fgraph > shadow > stack so that we can analyse this in more detail. > > On Mon, Jan 08, 2024 at 10:14:36AM +0900, Masami

Re: [PATCH v5 11/34] function_graph: Have the instances use their own ftrace_ops for filtering

2024-01-08 Thread Mark Rutland
On Mon, Jan 08, 2024 at 02:21:03PM +, Mark Rutland wrote: > On Mon, Jan 08, 2024 at 12:25:55PM +, Mark Rutland wrote: > > We also have HAVE_FUNCTION_GRAPH_RET_ADDR_PTR, but since the return address > > is > > not on the stack at the point function-entry is intercepted we use the FP as > >

Re: [PATCH v5 11/34] function_graph: Have the instances use their own ftrace_ops for filtering

2024-01-08 Thread Mark Rutland
On Mon, Jan 08, 2024 at 12:25:55PM +, Mark Rutland wrote: > We also have HAVE_FUNCTION_GRAPH_RET_ADDR_PTR, but since the return address is > not on the stack at the point function-entry is intercepted we use the FP as > the retp value -- in the absence of tail calls this will be different

Re: [PATCH v5 11/34] function_graph: Have the instances use their own ftrace_ops for filtering

2024-01-08 Thread Mark Rutland
Hi, There's a bit more of an info-dump below; I'll go try to dump the fgraph shadow stack so that we can analyse this in more detail. On Mon, Jan 08, 2024 at 10:14:36AM +0900, Masami Hiramatsu wrote: > On Fri, 5 Jan 2024 17:09:10 + > Mark Rutland wrote: > > > On Mon, Dec 18, 2023 at

Re: [PATCH v5 11/34] function_graph: Have the instances use their own ftrace_ops for filtering

2024-01-07 Thread Google
On Fri, 5 Jan 2024 17:09:10 + Mark Rutland wrote: > On Mon, Dec 18, 2023 at 10:13:46PM +0900, Masami Hiramatsu (Google) wrote: > > From: Steven Rostedt (VMware) > > > > Allow for instances to have their own ftrace_ops part of the fgraph_ops > > that makes the funtion_graph tracer filter on

Re: [PATCH v5 11/34] function_graph: Have the instances use their own ftrace_ops for filtering

2024-01-05 Thread Mark Rutland
On Mon, Dec 18, 2023 at 10:13:46PM +0900, Masami Hiramatsu (Google) wrote: > From: Steven Rostedt (VMware) > > Allow for instances to have their own ftrace_ops part of the fgraph_ops > that makes the funtion_graph tracer filter on the set_ftrace_filter file > of the instance and not the top

Re: [PATCH v5 11/34] function_graph: Have the instances use their own ftrace_ops for filtering

2023-12-25 Thread Google
Hi, On Mon, 18 Dec 2023 22:13:46 +0900 "Masami Hiramatsu (Google)" wrote: > @@ -408,15 +395,51 @@ int function_graph_enter(unsigned long ret, unsigned > long func, > return -EBUSY; > } > > +/* This is called from ftrace_graph_func() via ftrace */ > +int

[PATCH v5 11/34] function_graph: Have the instances use their own ftrace_ops for filtering

2023-12-18 Thread Masami Hiramatsu (Google)
From: Steven Rostedt (VMware) Allow for instances to have their own ftrace_ops part of the fgraph_ops that makes the funtion_graph tracer filter on the set_ftrace_filter file of the instance and not the top instance. This also change how the function_graph handles multiple instances on the