Re: [PATCH v5 3/3] printk: fix double printing with earlycon

2017-03-17 Thread Aleksey Makarov
On 03/16/2017 04:54 PM, Petr Mladek wrote: > On Thu 2017-03-16 13:36:35, Aleksey Makarov wrote: >> >> >> On 03/15/2017 07:58 PM, Petr Mladek wrote: >>> On Wed 2017-03-15 13:28:52, Aleksey Makarov wrote: [..] > I personally prefer v4. The braille console adds an unexpected > twist into the code

Re: [PATCH v5 3/3] printk: fix double printing with earlycon

2017-03-17 Thread Aleksey Makarov
On 03/16/2017 04:54 PM, Petr Mladek wrote: > On Thu 2017-03-16 13:36:35, Aleksey Makarov wrote: >> >> >> On 03/15/2017 07:58 PM, Petr Mladek wrote: >>> On Wed 2017-03-15 13:28:52, Aleksey Makarov wrote: [..] > I personally prefer v4. The braille console adds an unexpected > twist into the code

Re: [PATCH v5 3/3] printk: fix double printing with earlycon

2017-03-16 Thread Petr Mladek
On Thu 2017-03-16 13:36:35, Aleksey Makarov wrote: > > > On 03/15/2017 07:58 PM, Petr Mladek wrote: > > On Wed 2017-03-15 13:28:52, Aleksey Makarov wrote: > >> If a console was specified by ACPI SPCR table _and_ command line > >> parameters like "console=ttyAMA0" _and_ "earlycon" were specified,

Re: [PATCH v5 3/3] printk: fix double printing with earlycon

2017-03-16 Thread Petr Mladek
On Thu 2017-03-16 13:36:35, Aleksey Makarov wrote: > > > On 03/15/2017 07:58 PM, Petr Mladek wrote: > > On Wed 2017-03-15 13:28:52, Aleksey Makarov wrote: > >> If a console was specified by ACPI SPCR table _and_ command line > >> parameters like "console=ttyAMA0" _and_ "earlycon" were specified,

Re: [PATCH v5 3/3] printk: fix double printing with earlycon

2017-03-16 Thread Aleksey Makarov
On 03/15/2017 07:58 PM, Petr Mladek wrote: > On Wed 2017-03-15 13:28:52, Aleksey Makarov wrote: >> If a console was specified by ACPI SPCR table _and_ command line >> parameters like "console=ttyAMA0" _and_ "earlycon" were specified, >> then log messages appear twice. >> >> The root cause is

Re: [PATCH v5 3/3] printk: fix double printing with earlycon

2017-03-16 Thread Aleksey Makarov
On 03/15/2017 07:58 PM, Petr Mladek wrote: > On Wed 2017-03-15 13:28:52, Aleksey Makarov wrote: >> If a console was specified by ACPI SPCR table _and_ command line >> parameters like "console=ttyAMA0" _and_ "earlycon" were specified, >> then log messages appear twice. >> >> The root cause is

Re: [PATCH v5 3/3] printk: fix double printing with earlycon

2017-03-16 Thread Sergey Senozhatsky
On (03/15/17 17:58), Petr Mladek wrote: [..] > On Wed 2017-03-15 13:28:52, Aleksey Makarov wrote: > > If a console was specified by ACPI SPCR table _and_ command line > > parameters like "console=ttyAMA0" _and_ "earlycon" were specified, > > then log messages appear twice. > > > > The root cause

Re: [PATCH v5 3/3] printk: fix double printing with earlycon

2017-03-16 Thread Sergey Senozhatsky
On (03/15/17 17:58), Petr Mladek wrote: [..] > On Wed 2017-03-15 13:28:52, Aleksey Makarov wrote: > > If a console was specified by ACPI SPCR table _and_ command line > > parameters like "console=ttyAMA0" _and_ "earlycon" were specified, > > then log messages appear twice. > > > > The root cause

Re: [PATCH v5 3/3] printk: fix double printing with earlycon

2017-03-15 Thread Petr Mladek
On Wed 2017-03-15 13:28:52, Aleksey Makarov wrote: > If a console was specified by ACPI SPCR table _and_ command line > parameters like "console=ttyAMA0" _and_ "earlycon" were specified, > then log messages appear twice. > > The root cause is that the code traverses the list of specified >

Re: [PATCH v5 3/3] printk: fix double printing with earlycon

2017-03-15 Thread Petr Mladek
On Wed 2017-03-15 13:28:52, Aleksey Makarov wrote: > If a console was specified by ACPI SPCR table _and_ command line > parameters like "console=ttyAMA0" _and_ "earlycon" were specified, > then log messages appear twice. > > The root cause is that the code traverses the list of specified >

[PATCH v5 3/3] printk: fix double printing with earlycon

2017-03-15 Thread Aleksey Makarov
If a console was specified by ACPI SPCR table _and_ command line parameters like "console=ttyAMA0" _and_ "earlycon" were specified, then log messages appear twice. The root cause is that the code traverses the list of specified consoles (the `console_cmdline` array) and stops at the first match.

[PATCH v5 3/3] printk: fix double printing with earlycon

2017-03-15 Thread Aleksey Makarov
If a console was specified by ACPI SPCR table _and_ command line parameters like "console=ttyAMA0" _and_ "earlycon" were specified, then log messages appear twice. The root cause is that the code traverses the list of specified consoles (the `console_cmdline` array) and stops at the first match.